Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
From: Cole Poirier <colepoirier@gmail.com>
To: Libre-RISCV General Development <libre-riscv-dev@lists.libre-riscv.org>
Cc: Libre-RISCV General Development <libre-riscv-dev@lists.libre-riscv.org>
Subject: Re: [libre-riscv-dev] daily kan-ban update 23may2020
Date: Sat, 23 May 2020 15:32:49 -0700
Message-ID: <248833F3-C9C8-4BCE-8D87-7BE7F9512764@getmailspring.com> (raw)
In-Reply-To: <CAPweEDw+zpVOQSfcvanYTqxZh=qrsX0D9Nrh0bi1wBMtS9YkhA@mail.gmail.com>



On May 23 2020, at 3:27 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

> On Sat, May 23, 2020 at 11:20 PM Cole Poirier <colepoirier@gmail.com> wrote:
>> 
>> On May 23 2020, at 3:17 pm, Luke Kenneth Casson Leighton
>> <lkcl@lkcl.net> wrote:
>> 
>> > python3 fu/cr/test/test_pipe_caller.py
>> 
>> fu/logical/test/test_pipe_caller.py:
>> 
>> ``
>> Traceback (most recent call last):
>>   File "test/test_pipe_caller.py", line 14, in <module>
>>     from soc.fu.logical.pipeline import LogicalBasePipe
>>   File "/home/colepoirier/src/soc/src/soc/fu/logical/pipeline.py", line
>> 3, in <module>
>>     from soc.fu.logical.input_stage import LogicalInputStage
>> ModuleNotFoundError: No module named 'soc.fu.logical.input_stage'
>> ```
> 
> i missed that - that was what i needed.  so that was my fault, i've
> added (and pushed) them now.
> 
> it should have been the first reaction. not to try to "fix" the
> problem and then report an error in the method that you were trying to
> fix the issue (that you didn't clearly state existed)
> 
> the very first thing should have been "report the original error".

Learning. Will try to do this, but I expect to fail at least one more
time :)
 
>> Sorry I thought this was clear from: "Do I have to add something from
>> fu/logical/logical_input_record.py, or
>> add something else in order to use CommonInputStage properly?"
> 
> not at all.
> 
>>  I'll be more explicit in the future.
> 
> always a good idea, and something that everyone forgets (including me).
> 
> l.

Indeed. I'm trying to adapt to these new better habits of explicitness,
and the above 'explicitly state errors exist before doing something
fruitless/useless', but my old bad habits are clearly putting up a
fight. I will continue to try my best :)

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

  reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 14:29 Luke Kenneth Casson Leighton
2020-05-23 14:56 ` Tobias Platen
2020-05-23 15:15   ` Luke Kenneth Casson Leighton
2020-05-23 20:15     ` Cole Poirier
2020-05-23 20:36       ` Michael Nolan
2020-05-23 20:59         ` Luke Kenneth Casson Leighton
2020-05-23 21:38           ` Cole Poirier
2020-05-23 22:15             ` Luke Kenneth Casson Leighton
2020-05-23 22:23             ` Luke Kenneth Casson Leighton
2020-05-23 20:57       ` Luke Kenneth Casson Leighton
2020-05-23 21:21         ` Cole Poirier
2020-05-23 22:08         ` Cesar Strauss
2020-05-23 22:14           ` Luke Kenneth Casson Leighton
2020-05-23 22:16             ` Luke Kenneth Casson Leighton
2020-05-23 22:16               ` Luke Kenneth Casson Leighton
2020-05-23 22:17                 ` Luke Kenneth Casson Leighton
2020-05-23 22:18                   ` Luke Kenneth Casson Leighton
2020-05-23 22:20                   ` Cole Poirier
2020-05-23 22:27                     ` Luke Kenneth Casson Leighton
2020-05-23 22:32                       ` Cole Poirier [this message]
2020-05-23 22:39                         ` Luke Kenneth Casson Leighton
2020-05-23 22:23             ` Cole Poirier
2020-05-23 22:36               ` Luke Kenneth Casson Leighton
2020-05-23 22:59                 ` Cole Poirier
2020-05-23 23:01                   ` Luke Kenneth Casson Leighton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=248833F3-C9C8-4BCE-8D87-7BE7F9512764@getmailspring.com \
    --to=colepoirier@gmail.com \
    --cc=libre-riscv-dev@lists.libre-riscv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git