Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
To: Libre-RISCV General Development <libre-riscv-dev@lists.libre-riscv.org>
Subject: Re: [libre-riscv-dev] test failure when running nmutil tests on GitLab CI
Date: Thu, 26 Mar 2020 11:12:19 +0000
Message-ID: <CAPweEDyTm4STAnC4tXwLvrC0M8phzzP=xJc-Jg1DPA-BnsCVMQ@mail.gmail.com> (raw)
In-Reply-To: <20200326115158.221499f9f35dab24f9a47db3@platen-software.de>

On Thu, Mar 26, 2020 at 10:52 AM Tobias Platen
<libre-soc@platen-software.de> wrote:
>
> I had a similar error when I ugraded nmigen some months ago. I still don't remember how I solved that.

index c6a89e3..42f6fd6 100644
--- a/nmigen/compat/sim/__init__.py
+++ b/nmigen/compat/sim/__init__.py
@@ -19,7 +19,7 @@ def run_simulation(fragment_or_module, generators,
clocks={"sync": 10}, vcd_name

     if not isinstance(generators, dict):
         generators = {"sync": generators}
-        fragment.domains += ClockDomain("sync")
+        #fragment.domains += ClockDomain("sync")

     sim = Simulator(fragment)
     for domain, period in clocks.items():


except that now won't work on the very latest nmigen.

this however is fine:

commit 57d95b7f95dd37e2527db7b04be9ac8f324133e2 (HEAD -> master,
origin/master, origin/HEAD)
Merge: 7245b1e dfcf793
Author: Sebastien Bourdeauducq <sb@m-labs.hk>
Date:   Thu Feb 6 01:06:27 2020 +0800

    Merge branch 'master' of https://github.com/nmigen/nmigen

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  7:46 Jacob Lifshay
2020-03-26 10:13 ` Luke Kenneth Casson Leighton
2020-03-26 10:51   ` Tobias Platen
2020-03-26 11:12     ` Luke Kenneth Casson Leighton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPweEDyTm4STAnC4tXwLvrC0M8phzzP=xJc-Jg1DPA-BnsCVMQ@mail.gmail.com' \
    --to=lkcl@lkcl.net \
    --cc=libre-riscv-dev@lists.libre-riscv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git