From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
To: Libre-RISCV General Development <libre-riscv-dev@lists.libre-riscv.org>
Subject: Re: [libre-riscv-dev] daily kan-ban update 04aug2020
Date: Tue, 4 Aug 2020 18:32:34 +0100
Message-ID: <CAPweEDzDOo1bjQFZwLszgeRx5OEGFUXQAbO3PnZV2KAGaOgdUg@mail.gmail.com> (raw)
In-Reply-To: <20200804191858.1cee35c7f297e6a40eae5ce5@platen-software.de>
On Tue, Aug 4, 2020 at 6:19 PM Tobias Platen
<libre-soc@platen-software.de> wrote:
>
> today:
>
> unit test for DualPortSplitter
ok great. btw you saw that i had to revert a commit that you made:
please do ensure that you commit code that is "working" or at least
doesn't cause other people to not be able to do "work". i've had to
do this three times now.
as best i can tell when i wrote the unit test for LDSTSplitter, the
"logic" behind LDSTSplitter is correct, however the mask works on
*bits* not bytes (sigh).
also: the left port needs to be for when addr[4] == 0 and the right
port for when addr[4] == 1. this is achieved with a crossbar on
*both* the LD *and* ST data.
l.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
next prev parent reply index
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 12:45 Luke Kenneth Casson Leighton
2020-08-04 15:34 ` Luke Kenneth Casson Leighton
2020-08-04 17:18 ` Tobias Platen
2020-08-04 17:32 ` Luke Kenneth Casson Leighton [this message]
2020-08-05 16:40 ` Tobias Platen
2020-08-05 16:48 ` Tobias Platen
2020-08-05 17:08 ` Luke Kenneth Casson Leighton
2020-08-05 17:37 ` Tobias Platen
2020-08-05 18:39 ` Luke Kenneth Casson Leighton
2020-08-05 18:55 ` Tobias Platen
2020-08-05 19:02 ` Luke Kenneth Casson Leighton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPweEDzDOo1bjQFZwLszgeRx5OEGFUXQAbO3PnZV2KAGaOgdUg@mail.gmail.com \
--to=lkcl@lkcl.net \
--cc=libre-riscv-dev@lists.libre-riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Libre RISC-V Mailing list Archives (accessible via public-inbox)
Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev
Example config snippet for mirrors
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git