[libre-riscv-dev] [Bug 271] SigDecode in power_fields has extra spurious fields

[bugzilla-daemon@libre-riscv.org]

http://bugs.libre-riscv.org/show_bug.cgi?id=271

--- Comment #5 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Michael Nolan from comment #4)
> (In reply to Luke Kenneth Casson Leighton from comment #3)
> > what do you think of the idea of adding signals with the same name as
> > the fields?
> 
> 
> Haven't you already done this with power_fields/power_fieldsn?

if you recall i mentioned this a month ago particularly when we did those
recursive expressions.  the distinction between nmigen expressions and nmigen
signals is very important.

they are expressions rather than signals
which, if you recall, results in duplication of those expressions wherever they
are used (hence the massivr graphs ladt month despite the code only being a few
lines long)

if the expressions are used a hundred times then they are copied into the HDL a
hindred times because they are a nmigen AST tree fragment.

as signals, the *signal* would be copied and would show up in the yosys graphs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev