Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  3:09 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #73 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #71)
> (In reply to Luke Kenneth Casson Leighton from comment #68)
> > actually... cole, can you do the same thing as i just did with
> > msr_check_pr() create a function called trap(m, addr, nia)?
> > 
> > except this time it is a member function of the class, so trap(self, m,
> > addr, nia)
> > 
> > and just as you see i redid comb=m.d.comb in msr_check_pr, repeat/copy the
> > convenience variables that allow you to set self.o.nia etc etc
> > 
> > the reason for making this function is because you can see it is used twice
> > already.
> > 
> > also i am thinking it may be a good idea to add the address (0x700, etc)
> > actually to the trap_input_record and pass it in from the *decode* phase.
> 
> Sorry, I'm very shaky on the dynamic input records and how they work with
> the decoder.


will explain tomorrow when it is not 4am.
briefyly: every Record has a dictionary called fields.  by walking this
dictionary we can cheat and copy *only* a subset of fields... as long as the
names all match up.

see eq_from_execute1 and grep source code for where it is used.


> One difference between OP_TRAP and OP_SC is that the end of the OP_TRAP
> function is:
> 
> ```
> # take a copy of the current PC in SRR0
> comb += srr0_o.data.eq(cia_i)   # old PC
> comb += srr0_o.ok.eq(1)
> ```
> While the end of the OP_SC function is:
> 
> ```
> # and store the (next-after-return) PC in SRR0
> comb += srr0_o.data.eq(cia_i+4) # addr to begin from on return
> comb += srr0_o.ok.eq(1)
> ```
> 
> So should the function be:
> 
> ```
> def trap(self, m, addr, nia_o, srr0_o, trap_addr):
>     comb = m.d.comb
>     comb += nia_o.data.eq(trap_addr)
>     comb += nia_o.ok.eq(1)
> 
>     comb += srr0_o.data.eq(addr) # addr to begin from on return
>     comb += srr0_o.ok.eq(1)

yes! well done.  ok i would cut out srr0_o from those args and just redo them
inside the fn.

so now also cookie cut srr0_0 and nia_o from lines 89 and 90 "convenience"
variables.  see how that works?

so OP_SC should call self.trap(0xc00, cia_i+4) and OP_TRAP should be obvious.


> ```
> 
> The below is where my shakiness on the CompXOpSubset and the decoder starts
> to confuse me. If you can briefly explain that to me here, I can use this
> when doing the documentation after the tape-out deadline.

tomorrow.

late.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 365] ROCM/Libre-SOC GPU Opcode interoperability
From: bugzilla-daemon @ 2020-06-07  3:03 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-365-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=365

--- Comment #3 from Cole Poirier <colepoirier@gmail.com> ---
Dave Airlie

His graphics blog: https://airlied.blogspot.com/?m=1

Looks like he’s still at Red Hat Melbourne:
https://au.linkedin.com/in/dave-airlie-a2b07a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 365] ROCM/Libre-SOC GPU Opcode interoperability
From: bugzilla-daemon @ 2020-06-07  2:50 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-365-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=365

Cole Poirier <colepoirier@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colepoirier@gmail.com

--- Comment #2 from Cole Poirier <colepoirier@gmail.com> ---
I watched this LinuxConf talk that I think is salient you this discussion,
sometime in the last year and rewatched it today. But Mummy I don't want to use
CUDA - Open source GPU compute, https://m.youtube.com/watch?v=ZTq8wKnVUZ8. It
seems like Dave Aerlie at Red Hat Melbourne would be someone worth talking to
about this.


Not quite as related thoughts:

In the future perhaps the standardization of an open compute stack could be
undertaken by the OpenPower Foundation. Just spitballing here, I have no idea
of practicality or feasibility.

A related (OPF Linux conf) thing with this talk about booting faster
(https://m.youtube.com/watch?v=fTLsS_QZ8us) reminded me of our discussion of
using our single core iteration as a first stage boot processor, but I’m
posting it here as it’s so what related, and I could find the boot stage
processor discussion searching bugzilla. I’d like to migrate this to the
Systèmes Librés Bugzilla once we have that discussion and set up what we decide
on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  2:36 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #72 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #67)
> in the libreriscv submodule first to "git pull origin master" - watch out
> because submodules are a pain - then you can generate the emulator code.
> 
> run pywriter.py (see top-level Makefile).  then - and only then - will
> the simulator "understand" mtmsr.
> 
> you can inspect the results by looking at... errr... what did we say
> it was added to?  sprset.mdwn?
> 
> so... pywriter.py will.. err.. put that into... 1sec....
> soc/decoder/isa/sprset.py
> 
> [btw do *NOT* "git add" that to the repository (it's auto-generated.  we
>  do *NOT* add auto-generated files to the git repository, because they
>  change).]
> 
> example:  mcrxrx, from the sprset.mdwn file
> 
> * mcrxrx BF
> 
>     CR[4*BF+32:4*BF+35] <-  XER[OV] || XER[OV32] || XER[CA] || XER[CA32]
> 
> ---> is translated to, in sprset.py --->
> 
>     @inject()
>     def op_mcrxrx(self, CR):
>         CR[4 * BF + 32:4 * BF + 35 + 1] = concat(XER[OV], XER[OV32],
> XER[CA], XER[CA32]
>             )
>         return (CR,)
> 
> 
> at that point, you *should* be able to add something to
> soc/fu/trap/test/test_pipe_caller.py in class TrapTestCase
> 
> which i see you deleted all the unit tests (i usually leave one
> in there on cookie-cutting so that it's less typing when it comes
> to creating one.  now you will have to re-open one of the
> test_pipe_caller.py files to cut/paste an example from.  this is
> more work for you)
> 
> 
> here's the thing: it is highly likely that op_trap() from sprset.py
> will fail.  this because it's literally the first time that the emulator
> has ever seen the "trap" instruction, and that code also has to be written.
> 
> do not let this stop you from actually writing the unit test!
> 
> the unit test *is* the way to highlight that the code needs to be written!
> [this is called test-driven development]
> https://en.wikipedia.org/wiki/Test-driven_development

I'm having a difficult time understanding how to write the first test for class
TrapTestCase looking both at cr/test/test_pipe_caller and
logical/test/test_pipe_caller... Do I have to translate all the code that was
set up for CR into setting up for TRAP? Trying to think through it I can't
figure it out, and I suspect it is related to my previous comment about not
understanding how the test_pipe_caller, XXXInput/OutputData, CompALUOpSubset,
and CompTrapOpSubset, and the decoder, relate to and interact with each
other... I have a little idea of each but I'm doing the 'freeze cause I don't
understand' right now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] Scoreboard Tests
From: Luke Kenneth Casson Leighton @ 2020-06-07  2:21 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <829380E2-54C4-46C6-955E-BCCACF7A4164@gatech.edu>

On Sunday, June 7, 2020, Yehowshua <yimmanuel3@gatech.edu> wrote:

> Wrapping my head around the scoreboard.


it's... very few gates, with a lot of pieces to understand.  Thornton
highlighted that paradox in his book.

the code on its own it is inadviseable to focus on without having
*significant* amounts of uninterrupted time to pay attention to it.

in total it literally took 5-6 months to get first the knowledge, then do a
first draft, then find the bugs (in Mitch's book chapters - that was month
3), then implement instructions, and add the advanced feature such as
branch speculation thru shadowing.

load/store was then another month.  the multi-signal capability, another
month.

https://git.libre-soc.org/?p=soc.git;a=tree;f=src/soc/scoreboard;h=
> 5a0cc5e1d9bc2061c2a0eaa8d8b55f72af4c508f;hb=HEAD <
> https://git.libre-soc.org/?p=soc.git;a=tree;f=src/soc/scoreboard;h=
> 5a0cc5e1d9bc2061c2a0eaa8d8b55f72af4c508f;hb=HEAD>
>
> Do we have tests?


each python file has a unit test that in the simple modules i did not
maintain (cookie cut code).  the more complex ones, i did: it would be
absolutely flat-out an impossible task without them.

the primary method however was extreme close and careful examination of the
gtkwave timing traces, the yosys graphviz diagrams compared against Mitch's
book chapters, Thornton's original book, and the redrawn diagrams, which
are documented at the 6600scoreboard page

https://libre-soc.org/3d_gpu/architecture/6600scoreboard/

i recommend ignoring anything to do with LDST address matching, initially,
as they are derivatives of the Reg / FU DMs.

at some point i will draw out the Tomasulo algorithm and a series of
transformations like a stop-motion cartoon of drawings, and do a video that
shows how to get to 6600 from Tomasulo.

you really need to grasp and trust the algorithm first. looking at the code
itself, alone, will not help with that, very much.  running each module, to
get it to generate an ILANG file which you then examine in yosys with "show
top" you will find much more productive because it is far closer to Mitch
and Thornton's gate-level diagrams.

but even then, *only* when you have a strong grasp of the actual
algorithm.  as you're keenly aware by now, the academic literature will
only deeply mislead and misinform you in that regard.

l.




-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  2:09 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #71 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #68)
> actually... cole, can you do the same thing as i just did with
> msr_check_pr() create a function called trap(m, addr, nia)?
> 
> except this time it is a member function of the class, so trap(self, m,
> addr, nia)
> 
> and just as you see i redid comb=m.d.comb in msr_check_pr, repeat/copy the
> convenience variables that allow you to set self.o.nia etc etc
> 
> the reason for making this function is because you can see it is used twice
> already.
> 
> also i am thinking it may be a good idea to add the address (0x700, etc)
> actually to the trap_input_record and pass it in from the *decode* phase.

Sorry, I'm very shaky on the dynamic input records and how they work with the
decoder.

One difference between OP_TRAP and OP_SC is that the end of the OP_TRAP
function is:

```
# take a copy of the current PC in SRR0
comb += srr0_o.data.eq(cia_i)   # old PC
comb += srr0_o.ok.eq(1)
```
While the end of the OP_SC function is:

```
# and store the (next-after-return) PC in SRR0
comb += srr0_o.data.eq(cia_i+4) # addr to begin from on return
comb += srr0_o.ok.eq(1)
```

So should the function be:

```
def trap(self, m, addr, nia_o, srr0_o, trap_addr):
    comb = m.d.comb
    comb += nia_o.data.eq(trap_addr)
    comb += nia_o.ok.eq(1)

    comb += srr0_o.data.eq(addr) # addr to begin from on return
    comb += srr0_o.ok.eq(1)
```

The below is where my shakiness on the CompXOpSubset and the decoder starts to
confuse me. If you can briefly explain that to me here, I can use this when
doing the documentation after the tape-out deadline.

> that would allow us to do exceptions in a micro-code fashion, and also when
> it comes to illegal instructions or privileged ones, in the *decode* phase
> (PowerDecoder2) we *CHANGE* the opcode from whatever it is from the incoming
> instruction, into an OP_TRAP, set the trap address to 0x700 (or whatever)
> manually, and let the trap pipeline execute it.

(In reply to Luke Kenneth Casson Leighton from comment #69)
> see https://bugs.libre-soc.org/show_bug.cgi?id=325#c8
> 
> there, the only difference between OP_TRAP and that code is: one of the bits
> of SRR is changed (to indicate "priv execution")
> 
> we can pass that in as a flag to CompTrapOpSubset, and change the
> instruction to OP_TRAP.
> 
> illegal instruction trap happens. ta-daaa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 364] CXXRTL Python Interface
From: bugzilla-daemon @ 2020-06-07  1:56 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-364-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=364

--- Comment #7 from whitequark@whitequark.org ---
Great, thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 364] CXXRTL Python Interface
From: bugzilla-daemon @ 2020-06-07  1:54 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-364-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=364

--- Comment #6 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
hi whitequark i found the messages (private discussions with bob and michiel
from nlnet, april 4th and 11th) and forwarded them to you.

i will take responsibility for liasing with NLNet.  the short paragraph i wrote
in #175 should be enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  1:52 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #70 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #67)
> in the libreriscv submodule first to "git pull origin master" - watch out
> because submodules are a pain - then you can generate the emulator code.
> 
> run pywriter.py (see top-level Makefile).  then - and only then - will
> the simulator "understand" mtmsr.
> 
> you can inspect the results by looking at... errr... what did we say
> it was added to?  sprset.mdwn?
> 
> so... pywriter.py will.. err.. put that into... 1sec....
> soc/decoder/isa/sprset.py
> 
> [btw do *NOT* "git add" that to the repository (it's auto-generated.  we
>  do *NOT* add auto-generated files to the git repository, because they
>  change).]
> 
> example:  mcrxrx, from the sprset.mdwn file
> 
> * mcrxrx BF
> 
>     CR[4*BF+32:4*BF+35] <-  XER[OV] || XER[OV32] || XER[CA] || XER[CA32]
> 
> ---> is translated to, in sprset.py --->
> 
>     @inject()
>     def op_mcrxrx(self, CR):
>         CR[4 * BF + 32:4 * BF + 35 + 1] = concat(XER[OV], XER[OV32],
> XER[CA], XER[CA32]
>             )
>         return (CR,)
> 
> 
> at that point, you *should* be able to add something to
> soc/fu/trap/test/test_pipe_caller.py in class TrapTestCase
> 
> which i see you deleted all the unit tests (i usually leave one
> in there on cookie-cutting so that it's less typing when it comes
> to creating one.  now you will have to re-open one of the
> test_pipe_caller.py files to cut/paste an example from.  this is
> more work for you)
> 
> 
> here's the thing: it is highly likely that op_trap() from sprset.py
> will fail.  this because it's literally the first time that the emulator
> has ever seen the "trap" instruction, and that code also has to be written.
> 
> do not let this stop you from actually writing the unit test!
> 
> the unit test *is* the way to highlight that the code needs to be written!
> [this is called test-driven development]
> https://en.wikipedia.org/wiki/Test-driven_development

Very helpful, thank you. Will get to work on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  1:42 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #69 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
see https://bugs.libre-soc.org/show_bug.cgi?id=325#c8

there, the only difference between OP_TRAP and that code is: one of the bits of
SRR is changed (to indicate "priv execution")

we can pass that in as a flag to CompTrapOpSubset, and change the instruction
to OP_TRAP.

illegal instruction trap happens. ta-daaa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  1:32 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #68 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
actually... cole, can you do the same thing as i just did with msr_check_pr()
create a function called trap(m, addr, nia)?

except this time it is a member function of the class, so trap(self, m, addr,
nia)

and just as you see i redid comb=m.d.comb in msr_check_pr, repeat/copy the
convenience variables that allow you to set self.o.nia etc etc

the reason for making this function is because you can see it is used twice
already.

also i am thinking it may be a good idea to add the address (0x700, etc)
actually to the trap_input_record and pass it in from the *decode* phase.

that would allow us to do exceptions in a micro-code fashion, and also when it
comes to illegal instructions or privileged ones, in the *decode* phase
(PowerDecoder2) we *CHANGE* the opcode from whatever it is from the incoming
instruction, into an OP_TRAP, set the trap address to 0x700 (or whatever)
manually, and let the trap pipeline execute it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 364] CXXRTL Python Interface
From: bugzilla-daemon @ 2020-06-07  1:22 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-364-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=364

--- Comment #5 from whitequark@whitequark.org ---
(In reply to Luke Kenneth Casson Leighton from comment #1)
> Michiel asked us to get back with a proposal, and we did not hear back from you (whitequark) about that.

Was there a miscommunication? I'm not sure what you're referring to, here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] Scoreboard Tests
From: Yehowshua @ 2020-06-07  1:07 UTC (permalink / raw)
  To: Libre-RISCV General Development

Wrapping my head around the scoreboard.
https://git.libre-soc.org/?p=soc.git;a=tree;f=src/soc/scoreboard;h=5a0cc5e1d9bc2061c2a0eaa8d8b55f72af4c508f;hb=HEAD <https://git.libre-soc.org/?p=soc.git;a=tree;f=src/soc/scoreboard;h=5a0cc5e1d9bc2061c2a0eaa8d8b55f72af4c508f;hb=HEAD>

Do we have tests?

Yehowshua
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 366] Create new buzilla product "Systemes Libres Organization"
From: bugzilla-daemon @ 2020-06-07  1:03 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-366-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=366

--- Comment #2 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #1)
> i like this idea: it does however have implications that systemes-libre
> (the Company) is the same as "Libre-SOC the .org", which is not the case.
> i have no problem with using libre-soc as an interim home for SL.

I see your point. Is this the place to clarify the relationship between the two
entities? I think that this kind of clarification that needs to be handled in
an organized and publicly documented manner, which is why I was recommending we
use the libre-soc-org mailing list. Once this is clarified, perhaps it is
actually a systemes-libres-org mailing list that is needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 184] new mailing lists proposal for libre-soc.org
From: bugzilla-daemon @ 2020-06-07  0:57 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-184-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=184

--- Comment #19 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #18)
> (In reply to Cole Poirier from comment #17)
> > Since we have completed the domain move, and we now have pitch meetings with
> > potential investors coming up, I think it is essential that we set up the
> > Libre-SOC-Org mailing list.
> 
> they're done several weeks ago: i don't believe anyone realises that they're
> there:
> 
> http://lists.libre-soc.org/mailman/listinfo

You're right, I saw the emails in april, but didn't realize then that this was
complete. Thanks so much Alain! I think this discussion now falls under the
scope of bug #366.

> > In addition to this, I'd like to suggest that we have a short weekly meeting
> > (~30 min) to discuss organizational matters, which should be recorded and
> > made available somehow. I found the OPF virtual coffee call to be very good
> > for adding some more connection to our highly distributed team. I think the
> > purpose of these meeting should be to discuss and layout proposals, for
> > further discussion on, and subject to unanimous approval by the
> > Libre-SOC-Org mailing list. 
> > 
> > I'm writing this here because it's directly related to mailing lists. If you
> > find my idea of the video organizational chats to be worthy of further
> > discussion, then I think this will merit the creation of a new bug report. 
> 
> yes go for it, i like it.

Done. Bug #367 <https://bugs.libre-soc.org/show_bug.cgi?id=367>

> > I think it's also a good idea to add a new category of bug report to the
> > thee existing "Libre-SOC Website", "Libre-SOC First SOC", and "TODO IIT
> > Madras 180nm Foundry", perhaps "Systemes Libres Organization", such that
> > technical bugs are not mixed with non-technical bugs.
> 
> separate bugreport for that, too :)

Done. bug #366 <https://bugs.libre-soc.org/show_bug.cgi?id=366>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 366] Create new buzilla product "Systemes Libres Organization"
From: bugzilla-daemon @ 2020-06-07  0:55 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-366-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=366

--- Comment #1 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
i like this idea: it does however have implications that systemes-libre
(the Company) is the same as "Libre-SOC the .org", which is not the case.
i have no problem with using libre-soc as an interim home for SL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 367] New: Setup weekly 30 min organizational video call like OPF Virtual Coffee Calls
From: bugzilla-daemon @ 2020-06-07  0:52 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=367

            Bug ID: 367
           Summary: Setup weekly 30 min organizational video call like OPF
                    Virtual Coffee Calls
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Conferences
          Assignee: lkcl@lkcl.net
          Reporter: colepoirier@gmail.com
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

I'd like to suggest that we have a short weekly meeting (~30 min) to discuss
organizational matters, which should be recorded and made available somehow. I
found the OPF virtual coffee call to be very good for adding some more
connection to our highly distributed team. I think the purpose of these
meetings should be to discuss and layout proposals, for further discussion on,
and subject to unanimous approval by the Libre-SOC-Org mailing list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  0:51 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #67 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #64)
> (In reply to Luke Kenneth Casson Leighton from comment #62)
> > > Or is this  the one that is
> > > generated from parsing the csv files?
> > 
> > yes.  hence the need for the pseudocode.  until that exists there *is* no
> > mfmsr (etc) to test against!
> > 
> > in this case even the TRAP function has to be written.
> > 
> > this would (in python) move the SPRs about, set NIA to 0x700 blah blah.
> 
> This makes so much sense now and is very, very cool! Especially in light of
> your comments from comment #59 "actually i don't [completely understand
> pywriter.py]: it has been several months, and i wrote it very fast,
> to perform a minimal job!"
> 
> Regarding your comment on today's kanban daily update, "put a preliminary
> version of mtmsr into the mdwn for Cole to check", how do I go about
> checking the mdwn pseudo code with the emulator and the nmigen module?

in the libreriscv submodule first to "git pull origin master" - watch out
because submodules are a pain - then you can generate the emulator code.

run pywriter.py (see top-level Makefile).  then - and only then - will
the simulator "understand" mtmsr.

you can inspect the results by looking at... errr... what did we say
it was added to?  sprset.mdwn?

so... pywriter.py will.. err.. put that into... 1sec....
soc/decoder/isa/sprset.py

[btw do *NOT* "git add" that to the repository (it's auto-generated.  we
 do *NOT* add auto-generated files to the git repository, because they
 change).]

example:  mcrxrx, from the sprset.mdwn file

* mcrxrx BF

    CR[4*BF+32:4*BF+35] <-  XER[OV] || XER[OV32] || XER[CA] || XER[CA32]

---> is translated to, in sprset.py --->

    @inject()
    def op_mcrxrx(self, CR):
        CR[4 * BF + 32:4 * BF + 35 + 1] = concat(XER[OV], XER[OV32], XER[CA],
XER[CA32]
            )
        return (CR,)


at that point, you *should* be able to add something to
soc/fu/trap/test/test_pipe_caller.py in class TrapTestCase

which i see you deleted all the unit tests (i usually leave one
in there on cookie-cutting so that it's less typing when it comes
to creating one.  now you will have to re-open one of the
test_pipe_caller.py files to cut/paste an example from.  this is
more work for you)


here's the thing: it is highly likely that op_trap() from sprset.py
will fail.  this because it's literally the first time that the emulator
has ever seen the "trap" instruction, and that code also has to be written.

do not let this stop you from actually writing the unit test!

the unit test *is* the way to highlight that the code needs to be written!
[this is called test-driven development]
https://en.wikipedia.org/wiki/Test-driven_development


> > so the translator pushes an extra +1 out on the "end" of the slice.
> > 
> > you saw that when doing bperm.
> 
> Thanks this helps me understand the 'problem' even better than I did from
> your earlier comments. Also very ingenious.

just lazy :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 366] New: Create new buzilla product "Systemes Libres Organization"
From: bugzilla-daemon @ 2020-06-07  0:50 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=366

            Bug ID: 366
           Summary: Create new buzilla product "Systemes Libres
                    Organization"
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Conferences
          Assignee: lkcl@lkcl.net
          Reporter: colepoirier@gmail.com
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

I think we should create a new buzilla product "Systemes Libres Organization"
to avoid clutter in technical "Libre-SOC's first SOC". Bugs filed for this
product would not be sent to the 'libre-riscv general development list', but
instead be sent to 'Libre-soc-org -- Libre-Soc Governance', which Alain has had
ready for more than a month(!). Thanks Alain!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  0:44 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #66 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #65)
> superb.  i moved that to a separate function (msr_check_pr) because
> it's duplicated.  note that i used the fact that in *both* cases,
> the m.If() check comes from the argument that just got copied.
> 
>    comb += msr_o.data.eq(a_i)
>    with m.If(a_i[MSR_PR]):
> 
> is exactly the same as:
> 
>    comb += msr_o.eq(a_i)
>    with m.If(msr_o[MSR_PR]):
> 
> and therefore it is not necessary to pass a_i *and* msr_o into
> msr_check_pr().

Fantatsic!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  0:39 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #65 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #63)
> (In reply to Luke Kenneth Casson Leighton from comment #60)
> >  161                     with m.If(a_i[MSR_PR]):
> >  162                         msr_o.data[MSR_EE].eq(1)
> >  163                         msr_o.data[MSR_IR].eq(1)
> >  164                         msr_o.data[MSR_DR].eq(1)
> > 
> > and at line 185 comb += is missing
> 
> fixed

superb.  i moved that to a separate function (msr_check_pr) because
it's duplicated.  note that i used the fact that in *both* cases,
the m.If() check comes from the argument that just got copied.

   comb += msr_o.data.eq(a_i)
   with m.If(a_i[MSR_PR]):

is exactly the same as:

   comb += msr_o.eq(a_i)
   with m.If(msr_o[MSR_PR]):

and therefore it is not necessary to pass a_i *and* msr_o into
msr_check_pr().

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  0:38 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #64 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #62)
> > Or is this  the one that is
> > generated from parsing the csv files?
> 
> yes.  hence the need for the pseudocode.  until that exists there *is* no
> mfmsr (etc) to test against!
> 
> in this case even the TRAP function has to be written.
> 
> this would (in python) move the SPRs about, set NIA to 0x700 blah blah.

This makes so much sense now and is very, very cool! Especially in light of
your comments from comment #59 "actually i don't [completely understand
pywriter.py]: it has been several months, and i wrote it very fast,
to perform a minimal job!"

Regarding your comment on today's kanban daily update, "put a preliminary
version of mtmsr into the mdwn for Cole to check", how do I go about checking
the mdwn pseudo code with the emulator and the nmigen module?

> the syntax is python-indented (that was a pig to implement), and borrowed
> python concepts such as brackets.  i replaced operators such as = with <-
> and so on.
> 
> subscripted ranges were obviously not possible to do in ASCII so i did
> straight brackets python slices but kept the POWER numbering.
> 
> so the translator pushes an extra +1 out on the "end" of the slice.
> 
> you saw that when doing bperm.

Thanks this helps me understand the 'problem' even better than I did from your
earlier comments. Also very ingenious.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 184] new mailing lists proposal for libre-soc.org
From: bugzilla-daemon @ 2020-06-07  0:31 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-184-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=184

--- Comment #18 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #17)
> Since we have completed the domain move, and we now have pitch meetings with
> potential investors coming up, I think it is essential that we set up the
> Libre-SOC-Org mailing list.

they're done several weeks ago: i don't believe anyone realises that they're
there:

http://lists.libre-soc.org/mailman/listinfo

> In addition to this, I'd like to suggest that we have a short weekly meeting
> (~30 min) to discuss organizational matters, which should be recorded and
> made available somehow. I found the OPF virtual coffee call to be very good
> for adding some more connection to our highly distributed team. I think the
> purpose of these meeting should be to discuss and layout proposals, for
> further discussion on, and subject to unanimous approval by the
> Libre-SOC-Org mailing list. 
> 
> I'm writing this here because it's directly related to mailing lists. If you
> find my idea of the video organizational chats to be worthy of further
> discussion, then I think this will merit the creation of a new bug report. 

yes go for it, i like it.

> I think it's also a good idea to add a new category of bug report to the
> thee existing "Libre-SOC Website", "Libre-SOC First SOC", and "TODO IIT
> Madras 180nm Foundry", perhaps "Systemes Libres Organization", such that
> technical bugs are not mixed with non-technical bugs.

separate bugreport for that, too :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-07  0:31 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #63 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #60)
>  161                     with m.If(a_i[MSR_PR]):
>  162                         msr_o.data[MSR_EE].eq(1)
>  163                         msr_o.data[MSR_IR].eq(1)
>  164                         msr_o.data[MSR_DR].eq(1)
> 
> and at line 185 comb += is missing

fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 184] new mailing lists proposal for libre-soc.org
From: bugzilla-daemon @ 2020-06-07  0:29 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-184-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=184

Cole Poirier <colepoirier@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colepoirier@gmail.com

--- Comment #17 from Cole Poirier <colepoirier@gmail.com> ---
Since we have completed the domain move, and we now have pitch meetings with
potential investors coming up, I think it is essential that we set up the
Libre-SOC-Org mailing list.

In addition to this, I'd like to suggest that we have a short weekly meeting
(~30 min) to discuss organizational matters, which should be recorded and made
available somehow. I found the OPF virtual coffee call to be very good for
adding some more connection to our highly distributed team. I think the purpose
of these meeting should be to discuss and layout proposals, for further
discussion on, and subject to unanimous approval by the Libre-SOC-Org mailing
list. 

I'm writing this here because it's directly related to mailing lists. If you
find my idea of the video organizational chats to be worthy of further
discussion, then I think this will merit the creation of a new bug report. 

I think it's also a good idea to add a new category of bug report to the thee
existing "Libre-SOC Website", "Libre-SOC First SOC", and "TODO IIT Madras 180nm
Foundry", perhaps "Systemes Libres Organization", such that technical bugs are
not mixed with non-technical bugs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

page:   latest

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git