[libre-riscv-dev] added CI to soc.git as well as attempting to fix all tests

[libre-riscv-dev] added CI to soc.git as well as attempting to fix all tests

[Jacob Lifshay]

I pushed a new branch with my changes since basically everything is
changed and I didn't split my commits up very well.
On my computer, out of 234 tests, there are 4 errors and 1 failure.

https://git.libre-riscv.org/?p=soc.git;a=commitdiff;h=refs/heads/fix-tests

Jacob

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] added CI to soc.git as well as attempting to fix all tests

[Jacob Lifshay]

On Sun, Apr 5, 2020 at 5:17 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> I pushed a new branch with my changes since basically everything is
> changed and I didn't split my commits up very well.
> On my computer, out of 234 tests, there are 4 errors and 1 failure.
>
> https://git.libre-riscv.org/?p=soc.git;a=commitdiff;h=refs/heads/fix-tests

better url:
https://git.libre-riscv.org/?p=soc.git;a=tree;h=refs/heads/fix-tests;hb=refs/heads/fix-tests

Jacob

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] CI passes for soc.git!!!

[Jacob Lifshay]

On Sun, Apr 5, 2020 at 5:44 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> On Sun, Apr 5, 2020 at 5:17 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
> >
> > I pushed a new branch with my changes since basically everything is
> > changed and I didn't split my commits up very well.
> > On my computer, out of 234 tests, there are 4 errors and 1 failure.
> >
> > https://git.libre-riscv.org/?p=soc.git;a=commitdiff;h=refs/heads/fix-tests
>
> better url:
> https://git.libre-riscv.org/?p=soc.git;a=tree;h=refs/heads/fix-tests;hb=refs/heads/fix-tests

CI passes!!!

https://salsa.debian.org/Kazan-team/soc/-/jobs/649686

I added @unittest.skip() to test_iq, Luke or whoever can fix that test.

Jacob

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Luke Kenneth Casson Leighton]

On Mon, Apr 6, 2020 at 2:36 AM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> On Sun, Apr 5, 2020 at 5:44 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
> >
> > On Sun, Apr 5, 2020 at 5:17 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
> > >
> > > I pushed a new branch with my changes since basically everything is
> > > changed and I didn't split my commits up very well.
> > > On my computer, out of 234 tests, there are 4 errors and 1 failure.
> > >
> > > https://git.libre-riscv.org/?p=soc.git;a=commitdiff;h=refs/heads/fix-tests
> >
> > better url:
> > https://git.libre-riscv.org/?p=soc.git;a=tree;h=refs/heads/fix-tests;hb=refs/heads/fix-tests

ah.  just noticed.  i really can't stand branches.  they quickly
become an absolute nuisance, losing work, stopping (necessary)
communication and isolating the people who work on them from
absolutely everyone else.

working on the same branch requires that people communicate effectively.

> CI passes!!!

hurrah :)

> https://salsa.debian.org/Kazan-team/soc/-/jobs/649686
>
> I added @unittest.skip() to test_iq, Luke or whoever can fix that test.

can you please merge what you did (and work in master in future unless
there's a really *really* compelling and critical reason for doing
so)?

thx jacob.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Jacob Lifshay]

On Mon, Apr 6, 2020, 04:08 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
wrote:

>
> can you please merge what you did (and work in master in future unless
> there's a really *really* compelling and critical reason for doing
> so)?
>

So, just merge despite the commit mess?

Jacob
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Luke Kenneth Casson Leighton]

On Mon, Apr 6, 2020 at 3:37 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> On Mon, Apr 6, 2020, 04:08 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
> wrote:
>
> >
> > can you please merge what you did (and work in master in future unless
> > there's a really *really* compelling and critical reason for doing
> > so)?
> >
>
> So, just merge despite the commit mess?

yehyeh don't worry about it too much.  i nit-pick however that's in
case it needs a partial roll-back [that really bugs me: reversion of
partial commits is a bitch].  if you're sure it's fine just merge them
in.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Jacob Lifshay]

On Mon, Apr 6, 2020, 10:13 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
wrote:

> On Mon, Apr 6, 2020 at 3:37 PM Jacob Lifshay <programmerjake@gmail.com>
> wrote:
> >
> > On Mon, Apr 6, 2020, 04:08 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
> > wrote:
> >
> > >
> > > can you please merge what you did (and work in master in future unless
> > > there's a really *really* compelling and critical reason for doing
> > > so)?
> > >
> >
> > So, just merge despite the commit mess?
>
> yehyeh don't worry about it too much.  i nit-pick however that's in
> case it needs a partial roll-back [that really bugs me: reversion of
> partial commits is a bitch].  if you're sure it's fine just merge them
> in.
>

Merged but now it broke the build, so I pushed it to fix-tests. Will figure
it out a little later when I'm not sshing into my desktop through my phone.

Jacob
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Luke Kenneth Casson Leighton]

On Mon, Apr 6, 2020 at 8:15 PM Jacob Lifshay <programmerjake@gmail.com> wrote:

> Merged but now it broke the build, so I pushed it to fix-tests. Will figure
> it out a little later when I'm not sshing into my desktop through my phone.


*grin* ok

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Jacob Lifshay]

On Mon, Apr 6, 2020 at 1:35 PM Luke Kenneth Casson Leighton
<lkcl@lkcl.net> wrote:
>
> On Mon, Apr 6, 2020 at 8:15 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> > Merged but now it broke the build, so I pushed it to fix-tests. Will figure
> > it out a little later when I'm not sshing into my desktop through my phone.

Turns out that a later commit on master fixed it, so I pushed my
changes to master and deleted the fix-tests branch.

Jacob

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] CI passes for soc.git!!!

[Luke Kenneth Casson Leighton]

On Tuesday, April 7, 2020, Jacob Lifshay <programmerjake@gmail.com> wrote:

>
> Turns out that a later commit on master fixed it, so I pushed my
> changes to master and deleted the fix-tests branch.


ok cool.

i suspect it was the git submodules.

i believe it may be essential to do submodule updates then individual
separate commit of .gitmodules.

one way to do this: by committing groups of files *not* with git commit -a
but explicitly listing them

then finally the last commit with .gitmodules only

if a commit includes both files *and* an alteration to .gitmodules then
merging breaks.

frickin nuisance.  lots of people have given up using submodules because of
this

must research it properly.

l.




-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] added CI to soc.git as well as attempting to fix all tests

[Luke Kenneth Casson Leighton]

On Mon, Apr 6, 2020 at 1:44 AM Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> On Sun, Apr 5, 2020 at 5:17 PM Jacob Lifshay <programmerjake@gmail.com> wrote:
> >
> > I pushed a new branch with my changes since basically everything is
> > changed and I didn't split my commits up very well.
> > On my computer, out of 234 tests, there are 4 errors and 1 failure.

not bad.

> >
> > https://git.libre-riscv.org/?p=soc.git;a=commitdiff;h=refs/heads/fix-tests
>
> better url:
> https://git.libre-riscv.org/?p=soc.git;a=tree;h=refs/heads/fix-tests;hb=refs/heads/fix-tests

nice.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev