[libre-riscv-dev] [Bug 287] New: corrections to commit f17100d6c435aec47b17acb188272a7e9b3cf67d - bugzilla-daemon

From: bugzilla-daemon@libre-soc.org
To: libre-riscv-dev@lists.libre-riscv.org
Subject: [libre-riscv-dev] [Bug 287] New: corrections to commit f17100d6c435aec47b17acb188272a7e9b3cf67d
Date: Fri, 17 Apr 2020 16:41:17 +0000
Message-ID: <bug-287-13@https.bugs.libre-soc.org/> (raw)

https://bugs.libre-soc.org/show_bug.cgi?id=287

            Bug ID: 287
           Summary: corrections to commit
                    f17100d6c435aec47b17acb188272a7e9b3cf67d
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

* add suitable separate unit tests for both mul and carry.
  add them as *separate commits* with a message "unit test for sim multiply"
  and "unit tests for sim carry"

* remove the whitespace added around lines 140.  ensure that there is
  only one newline (not two)

* remove the redundant brackets in these two statements:

+        if(cry_out==1):
+            if(result > 0xFFFFFFFF):

* ensure that one space is between "if" and its "test"

   if cry_out == 1:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev