[libre-riscv-dev] [Bug 290] New: import error caused by soc.decoder.isa.all no longer being generated

[libre-riscv-dev] [Bug 290] New: import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

            Bug ID: 290
           Summary: import error caused by soc.decoder.isa.all no longer
                    being generated
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: normal
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: programmerjake@gmail.com
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

This is causing CI to fail and I finally got around to reproducing it locally:

After running git clean and rerunning src/doc/decoder/pseudo/pywriter.py:

ERROR: Failure: ModuleNotFoundError (No module named 'soc.decoder.isa.all')
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/site-packages/nose/failure.py",
line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File
"/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/site-packages/nose/loader.py",
line 418, in loadTestsFromName
    addr.filename, addr.module)
  File
"/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/site-packages/nose/importer.py",
line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File
"/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/site-packages/nose/importer.py",
line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/imp.py", line
235, in load_module
    return load_source(name, filename, file)
  File "/home/jacob/.virtualenvs/libre-riscv-venv/lib/python3.6/imp.py", line
172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 684, in _load
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File
"/home/jacob/projects/libreriscv/soc/src/soc/decoder/isa/test_caller.py", line
12, in <module>
    from soc.decoder.isa.all import ISA
ModuleNotFoundError: No module named 'soc.decoder.isa.all'


I'm on soc.git d557f4fb2a9e5b159c7abbdcd1d85712fabc6b9b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #1 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
it's autogenerated, so make something has to be run as part of the setup. 4am
now will look later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #2 from Jacob Lifshay <programmerjake@gmail.com> ---
To clarify, the error is triggered by running nosetests, pywriter.py completes
successfully.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #3 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/decoder/pseudo/pywriter.py;h=7a1c3f5ec22fcd0aa675963ab385007ad82c1b4e;hb=HEAD#l116

commented out.  moo?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #4 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #3)
> https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/decoder/pseudo/pywriter.py;h=7a1c3f5ec22fcd0aa675963ab385007ad82c1b4e;hb=HEAD#l116
> 
> commented out.  moo?

commented out in
https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=ade28272f9845d8eec21895a31c1b6ca012488ba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #5 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
that was a mistake when i added extra registers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

Jacob Lifshay <programmerjake@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #5)
> that was a mistake when i added extra registers

Uncommented it, which seems to have fixed this particular bug locally, will
have to see if it works in CI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[Jacob Lifshay]

On Mon, Apr 20, 2020, 21:48 <bugzilla-daemon@libre-soc.org> wrote:

> https://bugs.libre-soc.org/show_bug.cgi?id=290
>
> Jacob Lifshay <programmerjake@gmail.com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|CONFIRMED                   |RESOLVED
>          Resolution|---                         |FIXED
>
> --- Comment #6 from Jacob Lifshay <programmerjake@gmail.com> ---
> (In reply to Luke Kenneth Casson Leighton from comment #5)
> > that was a mistake when i added extra registers
>
> Uncommented it, which seems to have fixed this particular bug locally, will
> have to see if it works in CI.
>

Also fixed another import error where alu_hier was incorrectly imported.

Jacob

>
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 290] import error caused by soc.decoder.isa.all no longer being generated

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=290

--- Comment #7 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
excellent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev