[libre-riscv-dev] [Bug 297] New: nmutil "flatten" function already exists

[libre-riscv-dev] [Bug 297] New: nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

            Bug ID: 297
           Summary: nmutil "flatten" function already exists
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

nmigen already has a flatten function:
from nmigen._utils import flatten

whether we can rely on that staying there needs to be investigated
with whitequark

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

Jacob Lifshay <programmerjake@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lkcl@lkcl.net               |whitequark@whitequark.org
                 CC|                            |programmerjake@gmail.com,
                   |                            |whitequark@whitequark.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

--- Comment #1 from whitequark@whitequark.org ---
Anything that starts with _ is a private function according to Python
conventions and can be changed or removed without notice by nMigen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

--- Comment #2 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to whitequark from comment #1)
> Anything that starts with _ is a private function according to Python
> conventions and can be changed or removed without notice by nMigen.

That's what I thought. Would you be open to changing `flatten` to a public API,
or should we just keep using the duplicate in nmutil?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

--- Comment #3 from whitequark@whitequark.org ---
> Would you be open to changing `flatten` to a public API

Why should it be a public API of nmigen? It's a general purpose utility
function for iterables. It should be a public API of itertools, or another
package like that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

Jacob Lifshay <programmerjake@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|whitequark@whitequark.org   |lkcl@lkcl.net

--- Comment #4 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to whitequark from comment #3)
> > Would you be open to changing `flatten` to a public API
> 
> Why should it be a public API of nmigen? It's a general purpose utility
> function for iterables. It should be a public API of itertools, or another
> package like that.

yeah, makes sense.

Luke, unless you want to pursue that option, I'll let you close this as
won't-fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

[libre-riscv-dev] [Bug 297] nmutil "flatten" function already exists

[bugzilla-daemon]

https://bugs.libre-soc.org/show_bug.cgi?id=297

--- Comment #5 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
sigh.  it has to be a public function of a pacjsge... by us.  named nmutil.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev