Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* [libre-riscv-dev] [Bug 305] Create Pipelined ALU similar to alu_hier.py
From: bugzilla-daemon @ 2020-05-14 19:21 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-305-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=305

--- Comment #69 from Michael Nolan <mtnolan2640@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #67)
> (In reply to Luke Kenneth Casson Leighton from comment #66)
> 
> > i added popcount (because).  it looks like it works except test_cmpb is
> > not working
> 
> after updating submodules (will commit in a sec)
> 
>   File "/home/lkcl/src/libresoc/soc/src/soc/decoder/isa/fixedlogical.py",
> line 193, in op_cmpb
>     if eq(RS[8 * n:8 * n + 7 + 1], RB[8 * n:8 * n + 7 + 1]):
> NameError: name 'RS' is not defined

Oops, needed a patch (or figuring out why the compiler didn't include RS)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 305] Create Pipelined ALU similar to alu_hier.py
From: bugzilla-daemon @ 2020-05-14 19:27 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-305-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=305

--- Comment #70 from Michael Nolan <mtnolan2640@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #68)
>   File "/home/lkcl/src/libresoc/soc/src/soc/decoder/isa/fixedlogical.py",
> line 223, in op_prtyd
>     s = s / RS[i % 8 + 7]
> 
> erm... ermermerm... that doesn't look right.  divide?  instead of ^ (XOR)?
> 
> TypeError: unsupported operand type(s) for /: 'int' and 'SelectableInt'
> 
> i think, really, we need to do the same trick done with eq, ge etc, turn all
> operations from using python "op1 + op2" into "add(op1, op2)" and sort out
> the operands - convert to SelectableInt - in there.

There's no way they actually mean division there... If so, then every time that
bit is 0 you get a divide by 0...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 305] Create Pipelined ALU similar to alu_hier.py
From: bugzilla-daemon @ 2020-05-14 19:48 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-305-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=305

--- Comment #71 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Michael Nolan from comment #70)
> (In reply to Luke Kenneth Casson Leighton from comment #68)
> >   File "/home/lkcl/src/libresoc/soc/src/soc/decoder/isa/fixedlogical.py",
> > line 223, in op_prtyd
> >     s = s / RS[i % 8 + 7]
> > 
> > erm... ermermerm... that doesn't look right.  divide?  instead of ^ (XOR)?

> There's no way they actually mean division there... If so, then every time
> that bit is 0 you get a divide by 0...

yep it's a manual transcription error from when i extracted the text from the
PDF.  i've git pushed ^ instead of /, done the submodule update too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] virtual coffee openpower, in 50 minutes
From: Luke Kenneth Casson Leighton @ 2020-05-14 21:08 UTC (permalink / raw)
  To: Libre-RISCV General Development

https://openpowerfoundation.org/openpower-virtual-coffee-calls/
l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] quick write-up about microwatt and Libre-SOC HDL
From: Luke Kenneth Casson Leighton @ 2020-05-14 21:44 UTC (permalink / raw)
  To: Libre-RISCV General Development

just did a write-up saying "thank you" to the authors of microwatt
http://lists.mailinglist.openpowerfoundation.org/pipermail/openpower-hdl-cores/2020-May/thread.html
l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Cole Poirier @ 2020-05-14 21:48 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDy2_bBVfTFGyYAMvaTDDdxEmWR8jKRZOn7Z469ztvoswQ@mail.gmail.com>

Yesterday I worked on the script that automates the build and
installation of yosys and the various SYMByosys tools until when trying
to compile super_prove bitbucket had an internal error failed to load
for over half an hour. At that point I decided to try again the next
day. Today the bitbucket is working. I had to create two patches for the
abc-zz sub-dependency of super_prove, now super_prove compiles
successfully. Given that this prevents the successful compilation of an
entire yosys tool, should I make a PR with these small but significant
patches or should I just be satisfied that it now works for us and move
on? The abc-zz dependecy lives in a bitbucket repo
(https://bitbucket.org/niklaseen/abc-zz/src/default/) that is over five
years old and the super_prove bitbucket repo's
(https://bitbucket.org/sterin/super_prove_build/src/default/) most
recent commit is in 2017. Given this, what would you advise I do with
regard to a PR/moving on?

I'm hoping to finish the rest of the yosys tools in the script today,
and tomorrow finsish the rest of the HDL_workflow.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] quick write-up about microwatt and Libre-SOC HDL
From: Cole Poirier @ 2020-05-14 21:54 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDz0AUdWW=0o20hXurRCTzkn5evsVKLqJ1y+C1TfuLXWSg@mail.gmail.com>

On May 14 2020, at 2:44 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> just did a write-up saying "thank you" to the authors of microwatt
> http://lists.mailinglist.openpowerfoundation.org/pipermail/openpower-hdl-cores/2020-May/thread.html
> l.

A very lovely letter Luke. I believe that outreach like this will only
serve to enhance our relationship with the microwatt developers as well
as (hopefully) IBM and the OPF.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Michael Nolan @ 2020-05-14 22:00 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <1AC048A7-FAD5-41EE-B4BF-F622F72EBAF8@getmailspring.com>

On 5/14/20 5:48 PM, Cole Poirier wrote:
> Yesterday I worked on the script that automates the build and
> installation of yosys and the various SYMByosys tools until when trying
> to compile super_prove bitbucket had an internal error failed to load
> for over half an hour. At that point I decided to try again the next
> day. Today the bitbucket is working. I had to create two patches for the
> abc-zz sub-dependency of super_prove, now super_prove compiles
> successfully. Given that this prevents the successful compilation of an
> entire yosys tool, should I make a PR with these small but significant
> patches or should I just be satisfied that it now works for us and move
> on? The abc-zz dependecy lives in a bitbucket repo
> (https://bitbucket.org/niklaseen/abc-zz/src/default/) that is over five
> years old and the super_prove bitbucket repo's
> (https://bitbucket.org/sterin/super_prove_build/src/default/) most
> recent commit is in 2017. Given this, what would you advise I do with
> regard to a PR/moving on?
>
I've never been able to/never bothered to install super_prove or aiger 
for use with SymbiYosys. For running the formal proofs Libre-Soc has 
done, I think you only need one of the SMTBMC solvers (my recommendation 
is yices2).

--Michael


_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Cole Poirier @ 2020-05-14 22:29 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: libre-riscv-dev
In-Reply-To: <1b10f48d-7ca9-a0ea-9f5c-9b0aafd754b2@gmail.com>

On May 14 2020, at 3:00 pm, Michael Nolan <mtnolan2640@gmail.com> wrote:
> I've never been able to/never bothered to install super_prove or aiger 
> for use with SymbiYosys. For running the formal proofs Libre-Soc has 
> done, I think you only need one of the SMTBMC solvers (my
> recommendation 
> is yices2).
> 
> --Michael

Thanks for the tip Michael! I'll definitely keep your reccomendation to
use yices2 in mind when setting the default engine in the script (if I
do end up needing to set one, I'm not done yet), and for myself when I
start trying to use nmigen.

In that regard, Luke, after I am done with the scripts and the
modifications to the docs on the wiki, is there some testing
infrastructure that needs to be worked on, or should I try to start
learning to make nmigen HDL contributions to the project? Essentially,
what do you reccomend I do next that would be most helpful to the project?

Here is my code for a working super_prove installation in case you are
interested in trying it out:
```
 hg clone https://bitbucket.org/sterin/super_prove_build
 cd super_prove_build
 patch -u abc-zz/MetaSat/MiniSat2/System.cc <(echo "diff -r bde167bca3cd MetaSat/MiniSat2/System.cc
--- a/MetaSat/MiniSat2/System.cc    Thu Sep 14 01:44:08 2017 -0700
+++ b/MetaSat/MiniSat2/System.cc    Thu May 14 20:10:24 2020 +0000
@@ -20,6 +20,7 @@

 #include <signal.h>
 #include <stdio.h>
+#include <stdlib.h>

 #include "System.hh"

@@ -27,7 +28,6 @@

 #if defined(__linux__)

-#include <stdlib.h>

 static inline int memReadStat(int field)
 {
")
patch -u abc-zz/Bip/Main_bip.cc <(echo "diff -r bde167bca3cd Bip/Main_bip.cc
--- a/Bip/Main_bip.cc   Thu Sep 14 01:44:08 2017 -0700
+++ b/Bip/Main_bip.cc   Thu May 14 20:08:52 2020 +0000
@@ -508,8 +508,8 @@
 void writeCex(Out& out, NetlistRef N, const Cex& cex, uint orig_num_pis)
 {
     Vec<Pair<int,GLit> > ffs, pis;
-    For_Gatetype(N, gate_Flop, w) ffs.push(tuple(attr_Flop(w).number, w));
-    For_Gatetype(N, gate_PI  , w) pis.push(tuple(attr_PI  (w).number, w));
+    For_Gatetype(N, gate_Flop, w
)ffs.push(ZZ::tuple(attr_Flop(w).number, w));
+    For_Gatetype(N, gate_PI  , w) pis.push(ZZ::tuple(attr_PI 
(w).number, w));
     sort(ffs);
     sort(pis);

")
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release -G Ninja ..
ninja
ninja package
SPBIN=`find . -maxdepth 1 -name "super_prove*-Release.tar.gz"`
tar xvf $SPBIN -C /usr/local/bin/
cat << "EOF" > /usr/local/bin/suprove
#!/bin/bash
tool=super_prove; if [ "$1" != "${1#+}" ]; then tool="${1#+}"; shift; fi
exec /usr/local/bin/super_prove/bin/${tool}.sh "$@"
EOF
chmod +x /usr/local/bin/suprove
suprove
```

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-14 22:42 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <1AC048A7-FAD5-41EE-B4BF-F622F72EBAF8@getmailspring.com>

On Thu, May 14, 2020 at 10:48 PM Cole Poirier <colepoirier@gmail.com> wrote:
>
> Yesterday I worked on the script that automates the build and
> installation of yosys and the various SYMByosys tools until when trying
> to compile super_prove bitbucket had an internal error failed to load
> for over half an hour. At that point I decided to try again the next
> day. Today the bitbucket is working. I had to create two patches for the
> abc-zz sub-dependency of super_prove, now super_prove compiles
> successfully. Given that this prevents the successful compilation of an
> entire yosys tool, should I make a PR with these small but significant
> patches or should I just be satisfied that it now works for us and move
> on?

report them, put the patch into the git repo with the scripts, put the
link to the patch
on the wiki, and move on.

i only use i think z3solver, yices2 and one other - i didn't bother
with any of the
others.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-14 22:52 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <D51FC0DE-B374-474E-9FD3-E274B2452E18@getmailspring.com>

On Thu, May 14, 2020 at 11:29 PM Cole Poirier <colepoirier@gmail.com> wrote:

> In that regard, Luke, after I am done with the scripts and the
> modifications to the docs on the wiki, is there some testing
> infrastructure that needs to be worked on, or should I try to start
> learning to make nmigen HDL contributions to the project?

that would be a really good challenge to try anyway.  apart from anything
you'd be able to read / recognise the code as it evolves.

> Essentially, what do you reccomend I do next that would be most helpful to the project?

i have nooo idea :)  oh wait - i have an idea.  could you raise a
bugreport "bperm TODO",
look at the pseudo-code here:
    perm <- [0] * 8
    for i = 0 to 7
       index <- (RS)[8*i:8*i+7]
       if index < 64 then
            perm[i] <- (RB)[index]
       else
            perm[i] <- 0
    RA <- [0]*56 || perm[0:7]

and see if you can write that in nmigen?  this is the simulation
version (translated
from the above pseudo-code), it may be easier to understand:

    @inject()
    def op_bpermd(self, RS, RB):
        perm = concat(0, repeat=8)
        for i in range(0, 7 + 1):
            index = RS[8 * i:8 * i + 7 + 1]
            if lt(index, 64):
                perm[i] = RB[index]
            else:
                perm[i] = 0
        RA = concat(concat(0, repeat=56), perm[0:8])

notes:

* repeat=8 you use Repl
* concat you use Cat
* index you will have to actually store that in a temporary Signal (8
bits in length)

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Yehowshua @ 2020-05-14 23:16 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDxMq+A-8QNxn0obVU6M7Su=G4MMFfwfRHWuAPLGSpE8kw@mail.gmail.com>

More Create-X stuff. Working on the pinout tonight with Luke’s Python code - will try to have it ready by tomorrow afternoon.

Yehowshua
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15  8:28 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <459D5B7F-438F-47E1-8C81-D4E2C0D8417B@gatech.edu>

On Friday, May 15, 2020, Yehowshua <yimmanuel3@gatech.edu> wrote:

> More Create-X stuff. Working on the pinout tonight with Luke’s Python code
> - will try to have it ready by tomorrow afternoon.


good.  then we can review.  Rudi cannot start until we have a clear
specification.

l.



-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Tobias Platen @ 2020-05-15  9:07 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <CAPweEDw1ZjPuGrP8pKk9G+1i2-uRP+4mGNHAZ7Q=o7Och3=AaA@mail.gmail.com>

I've now done the conversion of countzero.vhdl and most of the testbench.

Tobias

On Fri, 15 May 2020 09:28:09 +0100
Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

> On Friday, May 15, 2020, Yehowshua <yimmanuel3@gatech.edu> wrote:
> 
> > More Create-X stuff. Working on the pinout tonight with Luke’s Python code
> > - will try to have it ready by tomorrow afternoon.
> 
> 
> good.  then we can review.  Rudi cannot start until we have a clear
> specification.
> 
> l.
> 
> 
> 
> -- 
> ---
> crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
> _______________________________________________
> libre-riscv-dev mailing list
> libre-riscv-dev@lists.libre-riscv.org
> http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev


-- 
Tobias Platen <libre-soc[at]platen-software[dot]de>

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15  9:09 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <20200515110731.0feafda72b6f40ba95d9bf49@platen-software.de>

On Friday, May 15, 2020, Tobias Platen <libre-soc@platen-software.de> wrote:

> I've now done the conversion of countzero.vhdl and most of the testbench.


fantastic.  next step, to put it into the Logical pipeline and write a
formal correctness proof (that's the bit that can receive donations!)



-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15  9:13 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDym7tKFw808vv5m1+u0D-JVFZJv1vRH79pBaKcgYiaPtg@mail.gmail.com>

https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=HEAD

remember tobias, i said do not use sync, replace that with comb on the
intermediate result.

apart from anything this will make the unit test a great deal simpler to
write.


l.


On Friday, May 15, 2020, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

>
>
> On Friday, May 15, 2020, Tobias Platen <libre-soc@platen-software.de>
> wrote:
>
>> I've now done the conversion of countzero.vhdl and most of the testbench.
>
>
> fantastic.  next step, to put it into the Logical pipeline and write a
> formal correctness proof (that's the bit that can receive donations!)
>
>
>
> --
> ---
> crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
>
>

-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15 10:55 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDy0WP7jxcKs_S7snEUcmsBq98nifNoha5um1fvQT-40dA@mail.gmail.com>

tobias, take note:

commit 4bca5df68e130da5d816cf0ab10182c4c1d27380 (HEAD -> master, origin/master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Fri May 15 11:54:35 2020 +0100

    make module combinatorial


---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68

On Fri, May 15, 2020 at 10:13 AM Luke Kenneth Casson Leighton
<lkcl@lkcl.net> wrote:
>
> https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=HEAD
>
> remember tobias, i said do not use sync, replace that with comb on the intermediate result.
>
> apart from anything this will make the unit test a great deal simpler to write.
>
>
> l.
>
>
> On Friday, May 15, 2020, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
>>
>>
>>
>> On Friday, May 15, 2020, Tobias Platen <libre-soc@platen-software.de> wrote:
>>>
>>> I've now done the conversion of countzero.vhdl and most of the testbench.
>>
>>
>> fantastic.  next step, to put it into the Logical pipeline and write a formal correctness proof (that's the bit that can receive donations!)
>>
>>
>>
>> --
>> ---
>> crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
>>
>
>
> --
> ---
> crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
>

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 14may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15 11:19 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDwW1Vm8JmhkMv6oLKizANSYUNPjygk3VV2f7pQgBGpi0A@mail.gmail.com>

hey tobias, totally cool, the countzero unit test works! :)
l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 311] New: countzero function for Logic Pipeline
From: bugzilla-daemon @ 2020-05-15 11:30 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=311

            Bug ID: 311
           Summary: countzero function for Logic Pipeline
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Mac OS
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

https://github.com/antonblanchard/microwatt/blob/master/countzero.vhdl
https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/countzero/countzero.py;hb=HEAD

to be added to logical pipeline

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 311] countzero function for Logic Pipeline
From: bugzilla-daemon @ 2020-05-15 11:30 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-311-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=311

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lkcl@lkcl.net               |libre-soc@platen-software.d
                   |                            |e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 311] countzero function for Logic Pipeline
From: bugzilla-daemon @ 2020-05-15 11:34 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-311-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=311

--- Comment #1 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
hm i don't think the count_right functionality is working correctly.  it
appears to count from the left up to the last 1, i.e. it returns
(64-countleftzeros)

this is count leading zeros:

* cntlzd.  RA,RS (Rc=1)

    n <- 0
    do while n < 64
      if (RS)[n]  = 1 then
         leave
      n <- n + 1
    RA <- n

and this is count trailing zeros:

* cnttzd.  RA,RS (Rc=1)

    n  <- 0
    do while n < 64
       if (RS)[63-n] = 0b1 then
            leave
       n  <- n + 1
    RA <- EXTZ64(n)

i am inclined to suggest that the entire input be inverted via a mux and
that encoder *not* try to do inversion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 311] countzero function for Logic Pipeline
From: bugzilla-daemon @ 2020-05-15 11:43 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-311-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=311

--- Comment #2 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
i *think* this fixes it:

--- a/src/soc/countzero/countzero.py
+++ b/src/soc/countzero/countzero.py
@@ -53,14 +53,14 @@ class ZeroCounter(Elaboratable):
                 with m.Else():
                     m.d.comb += ret.eq(3)
             with m.Else():
-                with m.If(v[0]):
-                    m.d.comb += ret.eq(0)
-                with m.Elif(v[1]):
-                    m.d.comb += ret.eq(1)
+                with m.If(v[3]):
+                    m.d.comb += ret.eq(3)
                 with m.Elif(v[2]):
                     m.d.comb += ret.eq(2)
+                with m.Elif(v[1]):
+                    m.d.comb += ret.eq(1)
                 with m.Else():
-                    m.d.comb += ret.eq(3)
+                    m.d.comb += ret.eq(0)
             return ret

         r = IntermediateResult()

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] daily kan-ban update 15may2020
From: Luke Kenneth Casson Leighton @ 2020-05-15 12:05 UTC (permalink / raw)
  To: Libre-RISCV General Development

yesterday, again, tried fixing the FSM for LD/ST Comp Unit.  several
hours and i was able to get ST to work but not LD.  or LD but not
update-mode.

this is getting very irritating and i need help with it: i am not
suited to doing complex time-dependent FSMs.

by contrast helping michael with the ALUs we made great progress, i
added popcount (tested), and parity (untested).

this morning, i am (still) on a call with MarketNext, and also
reviewed tobias's countzero conversion.  i will spend more time on the
LD/ST Comp Unit FSM later.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 311] countzero function for Logic Pipeline
From: bugzilla-daemon @ 2020-05-15 13:18 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-311-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=311

--- Comment #3 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
tobias i added this in:

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/logical/main_stage.py;h=76be8a6404b1648de20f10dc8a933b6c586d5a1c;hb=HEAD

next i'll put in a unit test into logical/test_pipe_caller.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] marketnext online call, earlier today
From: Luke Kenneth Casson Leighton @ 2020-05-15 13:44 UTC (permalink / raw)
  To: Libre-RISCV General Development

went very well.  it was over 2 hours (100 attendees), i got an
opportunity to speak for 5 minutes about our project, and for Shine,
the Director of the Marketnext Foundation, to mention the upcoming
Hackathon online session which will be May 30th.

there are at least 15 different groups who have expressed an interest
in helping with the project in the various different NLNet-funded
categories: this is a LOT of people to take on board at once, so one
of the things that will be important to do is to create separate
mailing lists for the different NLNet milestones: coriolis2 layout,
formal proofs, and so on, and have the bugtracker report to those
*different* locations rather than a single list.

we really, really need the LD/ST Comp Unit working by then, otherwise
i will be unable to focus on it.  to get it done i need help and
review.

also we need a branch / trap / anything-that-changes-the-PC Function
Unit.  from Samuel's early advice, he pointed out that any new
processor should get three instructions working:

* load
* add
* branch

from there, everything else falls into place.

l.

---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

page:   latest

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git