[libre-riscv-dev] test failure when running nmutil tests on GitLab CI

[libre-riscv-dev] test failure when running nmutil tests on GitLab CI

[Jacob Lifshay]

getting lots of errors like:

Traceback (most recent call last):
   File "/builds/Kazan-team/nmutil/.eggs/nose-1.3.7-py3.7.egg/nose/case.py",
line 198, in runTest
     self.test(*self.arg)
   File "/builds/Kazan-team/nmutil/src/nmutil/test/test_buf_pipe.py",
line 1227, in test0
     vcd_name="test_maskchain0.vcd")
   File "/builds/Kazan-team/nmigen/nmigen/compat/sim/__init__.py",
line 22, in run_simulation
     fragment.domains += ClockDomain("sync")
 AttributeError: 'MaskCancellablePipe' object has no attribute 'domains'

See for details:
https://salsa.debian.org/Kazan-team/nmutil/-/jobs/630414

Jacob

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] test failure when running nmutil tests on GitLab CI

[Luke Kenneth Casson Leighton]

On Thu, Mar 26, 2020 at 7:46 AM Jacob Lifshay <programmerjake@gmail.com> wrote:

>      fragment.domains += ClockDomain("sync")
>  AttributeError: 'MaskCancellablePipe' object has no attribute 'domains'

ah frickin 'ell.  you'll need to use a less up-to-date

there are dozens of simulations that need "conversion".

my feeling is: screw that, we write our own function which emulates
the old behaviour of run_simulation(), of 6 months ago.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] test failure when running nmutil tests on GitLab CI

[Tobias Platen]

I had a similar error when I ugraded nmigen some months ago. I still don't remember how I solved that.

t.

On Thu, 26 Mar 2020 10:13:05 +0000
Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

> On Thu, Mar 26, 2020 at 7:46 AM Jacob Lifshay <programmerjake@gmail.com> wrote:
> 
> >      fragment.domains += ClockDomain("sync")
> >  AttributeError: 'MaskCancellablePipe' object has no attribute 'domains'
> 
> ah frickin 'ell.  you'll need to use a less up-to-date
> 
> there are dozens of simulations that need "conversion".
> 
> my feeling is: screw that, we write our own function which emulates
> the old behaviour of run_simulation(), of 6 months ago.
> 
> l.
> 
> _______________________________________________
> libre-riscv-dev mailing list
> libre-riscv-dev@lists.libre-riscv.org
> http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev




_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

Re: [libre-riscv-dev] test failure when running nmutil tests on GitLab CI

[Luke Kenneth Casson Leighton]

On Thu, Mar 26, 2020 at 10:52 AM Tobias Platen
<libre-soc@platen-software.de> wrote:
>
> I had a similar error when I ugraded nmigen some months ago. I still don't remember how I solved that.

index c6a89e3..42f6fd6 100644
--- a/nmigen/compat/sim/__init__.py
+++ b/nmigen/compat/sim/__init__.py
@@ -19,7 +19,7 @@ def run_simulation(fragment_or_module, generators,
clocks={"sync": 10}, vcd_name

     if not isinstance(generators, dict):
         generators = {"sync": generators}
-        fragment.domains += ClockDomain("sync")
+        #fragment.domains += ClockDomain("sync")

     sim = Simulator(fragment)
     for domain, period in clocks.items():


except that now won't work on the very latest nmigen.

this however is fine:

commit 57d95b7f95dd37e2527db7b04be9ac8f324133e2 (HEAD -> master,
origin/master, origin/HEAD)
Merge: 7245b1e dfcf793
Author: Sebastien Bourdeauducq <sb@m-labs.hk>
Date:   Thu Feb 6 01:06:27 2020 +0800

    Merge branch 'master' of https://github.com/nmigen/nmigen

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev