Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
From: bugzilla-daemon@libre-soc.org
To: libre-riscv-dev@lists.libre-riscv.org
Subject: [libre-riscv-dev] [Bug 313] Create Branch Pipeline for POWER9
Date: Fri, 22 May 2020 08:44:57 +0000
Message-ID: <bug-313-13-7XqI8hXm6u@https.bugs.libre-soc.org/> (raw)
In-Reply-To: <bug-313-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=313

--- Comment #32 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Luke Kenneth Casson Leighton from comment #31)

> the idea is to use 3 bits of BI to look up CR00 to 7

(3 MSBs)

> then in OP_BC look up the remaining 2 bits of BI to select which bit of CRn
> is to be used, right?

(2 LSBs)

except, small issue: endian-ness looks like it will be an issue.

in main_stage.py the bit-order is reversed using [31-BI]

        # The bit of CR selected by BI
        cr_bit = Signal(reset_less=True)
        comb += cr_bit.eq((self.i.cr & (1<<(31-BI))) != 0)

if we are to reduce self.i.cr (BranchInputData.cr) to 4 bits,
should that not be
        comb += cr_bit.eq((self.i.cr & (1<<(3-BI))) != 0)

but also, back in power_decoder2.py, for DecodeCRIn, what about here?

            with m.Case(CRInSel.BI):
                comb += self.cr_bitfield.data.eq(self.dec.BI[2:5])
                comb += self.cr_bitfield.ok.eq(1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

  parent reply index

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 15:30 [libre-riscv-dev] [Bug 313] New: " bugzilla-daemon
2020-05-15 15:30 ` [libre-riscv-dev] [Bug 313] " bugzilla-daemon
2020-05-15 15:33 ` bugzilla-daemon
2020-05-15 17:26 ` bugzilla-daemon
2020-05-15 17:41 ` bugzilla-daemon
2020-05-15 18:58 ` bugzilla-daemon
2020-05-15 19:01 ` bugzilla-daemon
2020-05-15 19:14 ` bugzilla-daemon
2020-05-15 19:17 ` bugzilla-daemon
2020-05-15 19:28 ` bugzilla-daemon
2020-05-15 19:33 ` bugzilla-daemon
2020-05-15 19:36 ` bugzilla-daemon
2020-05-15 20:11 ` bugzilla-daemon
2020-05-15 20:31 ` bugzilla-daemon
2020-05-15 20:39 ` bugzilla-daemon
2020-05-15 20:46 ` bugzilla-daemon
2020-05-15 21:07 ` bugzilla-daemon
2020-05-15 21:26 ` bugzilla-daemon
2020-05-15 21:27 ` bugzilla-daemon
2020-05-15 22:23 ` bugzilla-daemon
2020-05-15 23:49 ` bugzilla-daemon
2020-05-16  0:56 ` bugzilla-daemon
2020-05-17 17:37 ` bugzilla-daemon
2020-05-17 18:11 ` bugzilla-daemon
2020-05-17 19:17 ` bugzilla-daemon
2020-05-19 12:30 ` bugzilla-daemon
2020-05-19 18:09 ` bugzilla-daemon
2020-05-19 18:30 ` bugzilla-daemon
2020-05-19 21:02 ` bugzilla-daemon
2020-05-19 21:06 ` bugzilla-daemon
2020-05-19 21:09   ` Jacob Lifshay
2020-05-19 21:14 ` bugzilla-daemon
2020-05-19 21:19 ` bugzilla-daemon
2020-05-19 21:22 ` bugzilla-daemon
2020-05-19 21:41 ` bugzilla-daemon
2020-05-20 18:43   ` [libre-riscv-dev] monorepo Jacob Lifshay
2020-05-20 19:08     ` Luke Kenneth Casson Leighton
2020-05-20 19:17       ` Luke Kenneth Casson Leighton
2020-05-19 21:44 ` [libre-riscv-dev] [Bug 313] Create Branch Pipeline for POWER9 bugzilla-daemon
2020-05-22  2:39 ` bugzilla-daemon
2020-05-22  8:44 ` bugzilla-daemon [this message]
2020-05-22 13:10 ` bugzilla-daemon
2020-05-22 13:46 ` bugzilla-daemon
2020-05-22 14:11 ` bugzilla-daemon
2020-05-22 14:33 ` bugzilla-daemon
2020-05-22 14:51 ` bugzilla-daemon
2020-05-22 18:21 ` bugzilla-daemon
2020-05-23  1:29 ` bugzilla-daemon
2020-05-23  3:06 ` bugzilla-daemon
2020-06-01 20:39 ` bugzilla-daemon
2020-06-02 18:27 ` bugzilla-daemon
2020-06-02 18:43 ` bugzilla-daemon
2020-06-02 19:09 ` bugzilla-daemon
2020-06-02 20:11 ` bugzilla-daemon
2020-06-02 20:19 ` bugzilla-daemon
2020-06-02 20:30 ` bugzilla-daemon
2020-06-02 21:03 ` bugzilla-daemon
2020-06-02 21:33 ` bugzilla-daemon
2020-06-02 21:38 ` bugzilla-daemon
2020-06-02 22:41 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-313-13-7XqI8hXm6u@https.bugs.libre-soc.org/ \
    --to=bugzilla-daemon@libre-soc.org \
    --cc=libre-riscv-dev@lists.libre-riscv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git