Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-23 23:10 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

--- Comment #11 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
brilliant, just saw this, Cesar.  confirmed that it is functional.

commit 260625df9309f8f35541207cab431dd8dba90c5a
Author: Cesar Strauss <cestrauss@gmail.com>
Date:   Sat May 23 19:52:08 2020 -0300

    Add a few test cases with zero_a set, in combination with imm_ok


so the next one is: we need something that's a bit more sophisticated,
designed more along the lines of test_inout_mux_pipe.py:

https://git.libre-soc.org/?p=nmutil.git;a=blob;f=src/nmutil/test/test_inout_mux_pipe.py;h=03fddde0f7ab12ec9023fc57b913442ba42c120a;hb=HEAD#l52

not quite that sophisticated, but close.

basically, we need:

* one function (similar to TestInput.send) which takes care of *one*
  REQ_READ and GO_RD signalling bit.  it should monitor:
  self.rd.req[N], then set self.rd.go[N] for *one* cycle (one blank yield)
  then set it self.rd.go[N] back to zero and confirm (assert) that
  self.rd.req[N] has gone to zero

* another function (similar again to TestInput.rcv) which does the same
  thing for REQ_WRITE and GO_WRITE.

* another function - a very simple one - which sets issue_i
  for one cycle (yield in between), then waits for "self.busy" to drop to 0

we can make it more sophisticated as we go along.

it should be... only... about... 80 lines of code, at a guess.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 23:01 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <0961ED2D-D6C5-4A7D-9F34-95EEDE121987@getmailspring.com>

On Sat, May 23, 2020 at 11:59 PM Cole Poirier <colepoirier@gmail.com> wrote:
> > should keep you occupied for all of ooo 5 minutes whilst i think.
>
> Woohoo! Finally finished a piece of code!

aaawesome.

> I did the above and
> commit-pushed it. Have a social function to attend to now, if you think
> of something for me to do please post it here and I will try it in the morning.

enjoy.  willdo.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Cole Poirier @ 2020-05-23 22:59 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDxzR2-eca=NUvg32GLE+HCBfb7b02z_oceGzmVmAAC0kA@mail.gmail.com>

On May 23 2020, at 3:36 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> ok so i sorted the missing files that i'd forgotten to commit.  that
> unblocks (at least) 2 people from proceeding.  whew.  ok now what.
> 
> oh i know.  i got one.
> 
> can you look at soc/fu/compunits.py and add some extra imports which
> create the following classes:
> 
> * BranchFunctionUnit
> * ShiftRotFunctionUnit
> etc. etc.
> 
> it should be blindingly obvious what to do.
> 
> should keep you occupied for all of ooo 5 minutes whilst i think.

Woohoo! Finally finished a piece of code! I did the above and
commit-pushed it. Have a social function to attend to now, if you think
of something for me to do please post it here and I will try it in the morning.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 341] unit tests needed for soc.fu.compunits (shared with soc.fu.*/test_pipe_caller.py)
From: bugzilla-daemon @ 2020-05-23 22:58 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-341-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=341

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.libre-soc.org/
                   |                            |show_bug.cgi?id=342

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 342] formal proof of soc.fu.compunits.FunctionUnitBaseSingle needed
From: bugzilla-daemon @ 2020-05-23 22:58 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-342-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=342

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.libre-soc.org/
                   |                            |show_bug.cgi?id=341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 342] formal proof of soc.fu.compunits.FunctionUnitBaseSingle needed
From: bugzilla-daemon @ 2020-05-23 22:57 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-342-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=342

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Source Code                 |Formal Verification
    NLnet milestone|---                         |NLNet.2019.10.Formal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 342] New: formal proof of soc.fu.compunits.FunctionUnitBaseSingle needed
From: bugzilla-daemon @ 2020-05-23 22:57 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=342

            Bug ID: 342
           Summary: formal proof of
                    soc.fu.compunits.FunctionUnitBaseSingle needed
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

we need a formal proof of both MultiCompUnit and FunctionUnitBaseSingle.
a formal proof of the ALU that is used is *not* necessary, so a very
basic (stub) ALU can be created and used.

however, the proof needs to be written to test the following:

* 1 to 3 src input operands
* 1 to 2 dest operands
* with *and without* zero_a capabiltiy
* with *and without* immediate capability

so that's actually quite a lot of combinations: 3x2x2x2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-23 22:52 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.libre-soc.org/
                   |                            |show_bug.cgi?id=341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 341] unit tests needed for soc.fu.compunits (shared with soc.fu.*/test_pipe_caller.py)
From: bugzilla-daemon @ 2020-05-23 22:52 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-341-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=341

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |305, 318
           See Also|                            |https://bugs.libre-soc.org/
                   |                            |show_bug.cgi?id=336


Referenced Bugs:

https://bugs.libre-soc.org/show_bug.cgi?id=305
[Bug 305] Create Pipelined ALU similar to alu_hier.py
https://bugs.libre-soc.org/show_bug.cgi?id=318
[Bug 318] fix LDSTCompUnit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 341] New: unit tests needed for soc.fu.compunits (shared with soc.fu.*/test_pipe_caller.py)
From: bugzilla-daemon @ 2020-05-23 22:50 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=341

            Bug ID: 341
           Summary: unit tests needed for soc.fu.compunits (shared with
                    soc.fu.*/test_pipe_caller.py)
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

we need some test infrastructure that does exactly the same as
every single one of the test_pipe_caller.py unit tests, except
using ALUFunctionUnit, CRFunctionUnit etc. instead of
ALUBasePipe+ALUPipeSpec, CRBasePipe+CRPipeSpec etc.

the only pieces of code that need to change to achieve this is
how the inputs are set up, and the outputs obtained.

this basically means generalising each test_pipe_caller.py
TestRunner.run_all().process() function, so that instead
of explicitly targetting the alu instance:

                    vld = yield alu.n.valid_o
                    while not vld:
                        yield
                        vld = yield alu.n.valid_o
                    yield
                    alu_out = yield alu.n.data_o.o

instead it allows a parameterised selection of  the MultiCompUnit API /
data-synchronisation method (see experiment/compalu_multi.py tests):

    yield dut.issue_i.eq(1)
    yield
    yield dut.issue_i.eq(0)
    yield
    yield dut.rd.go.eq(0b11)
    while True:
        yield
        rd_rel_o = yield dut.rd.rel
        print ("rd_rel", rd_rel_o)
        if rd_rel_o:
            break

(actually, this ties in with Cesar's task, somewhat).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:39 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <248833F3-C9C8-4BCE-8D87-7BE7F9512764@getmailspring.com>

On Sat, May 23, 2020 at 11:32 PM Cole Poirier <colepoirier@gmail.com> wrote:
> > the very first thing should have been "report the original error".
>
> Learning. Will try to do this, but I expect to fail at least one more
> time :)

:)

the immediate response to report the missing module can be easily
deduced from the workflow.

you *know* that people - everyone - should only commit code that
"works" (passes unit tests).  therefore, if someone commits code that
breaks, and it says "import module not found", you *know* that they
must have forgotten to commit a module.

.. yes?

easy, eh?

> Indeed. I'm trying to adapt to these new better habits of explicitness,
> and the above 'explicitly state errors exist before doing something
> fruitless/useless', but my old bad habits are clearly putting up a
> fight. I will continue to try my best :)

:)

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:36 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <33C444DE-A89B-4D29-8F47-7EA2CE3A190D@getmailspring.com>

On Sat, May 23, 2020 at 11:23 PM Cole Poirier <colepoirier@gmail.com> wrote:

> Will do! I'll await your directions.

ok so i sorted the missing files that i'd forgotten to commit.  that
unblocks (at least) 2 people from proceeding.  whew.  ok now what.

oh i know.  i got one.

can you look at soc/fu/compunits.py and add some extra imports which
create the following classes:

* BranchFunctionUnit
* ShiftRotFunctionUnit
etc. etc.

it should be blindingly obvious what to do.

should keep you occupied for all of ooo 5 minutes whilst i think.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 316] bperm TODO
From: bugzilla-daemon @ 2020-05-23 22:35 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-316-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=316

--- Comment #94 from Cole Poirier <colepoirier@gmail.com> ---
Michael, the unit tests for fu/logical/test/test_pipe_caller.py has been fixed
by luke, and now produces a failed test for my module bpermd. Thanks for your
help!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Cole Poirier @ 2020-05-23 22:32 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDw+zpVOQSfcvanYTqxZh=qrsX0D9Nrh0bi1wBMtS9YkhA@mail.gmail.com>



On May 23 2020, at 3:27 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

> On Sat, May 23, 2020 at 11:20 PM Cole Poirier <colepoirier@gmail.com> wrote:
>> 
>> On May 23 2020, at 3:17 pm, Luke Kenneth Casson Leighton
>> <lkcl@lkcl.net> wrote:
>> 
>> > python3 fu/cr/test/test_pipe_caller.py
>> 
>> fu/logical/test/test_pipe_caller.py:
>> 
>> ``
>> Traceback (most recent call last):
>>   File "test/test_pipe_caller.py", line 14, in <module>
>>     from soc.fu.logical.pipeline import LogicalBasePipe
>>   File "/home/colepoirier/src/soc/src/soc/fu/logical/pipeline.py", line
>> 3, in <module>
>>     from soc.fu.logical.input_stage import LogicalInputStage
>> ModuleNotFoundError: No module named 'soc.fu.logical.input_stage'
>> ```
> 
> i missed that - that was what i needed.  so that was my fault, i've
> added (and pushed) them now.
> 
> it should have been the first reaction. not to try to "fix" the
> problem and then report an error in the method that you were trying to
> fix the issue (that you didn't clearly state existed)
> 
> the very first thing should have been "report the original error".

Learning. Will try to do this, but I expect to fail at least one more
time :)
 
>> Sorry I thought this was clear from: "Do I have to add something from
>> fu/logical/logical_input_record.py, or
>> add something else in order to use CommonInputStage properly?"
> 
> not at all.
> 
>>  I'll be more explicit in the future.
> 
> always a good idea, and something that everyone forgets (including me).
> 
> l.

Indeed. I'm trying to adapt to these new better habits of explicitness,
and the above 'explicitly state errors exist before doing something
fruitless/useless', but my old bad habits are clearly putting up a
fight. I will continue to try my best :)

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:27 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <1A8469A7-6896-4AA1-80E9-CC9CA0FCF8C9@getmailspring.com>

On Sat, May 23, 2020 at 11:20 PM Cole Poirier <colepoirier@gmail.com> wrote:
>
> On May 23 2020, at 3:17 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
>
> > python3 fu/cr/test/test_pipe_caller.py
>
> fu/logical/test/test_pipe_caller.py:
>
> ``
> Traceback (most recent call last):
>   File "test/test_pipe_caller.py", line 14, in <module>
>     from soc.fu.logical.pipeline import LogicalBasePipe
>   File "/home/colepoirier/src/soc/src/soc/fu/logical/pipeline.py", line
> 3, in <module>
>     from soc.fu.logical.input_stage import LogicalInputStage
> ModuleNotFoundError: No module named 'soc.fu.logical.input_stage'
> ```

i missed that - that was what i needed.  so that was my fault, i've
added (and pushed) them now.

it should have been the first reaction. not to try to "fix" the
problem and then report an error in the method that you were trying to
fix the issue (that you didn't clearly state existed)

the very first thing should have been "report the original error".


> Sorry I thought this was clear from: "Do I have to add something from
> fu/logical/logical_input_record.py, or
> add something else in order to use CommonInputStage properly?"

not at all.

>  I'll be more explicit in the future.

always a good idea, and something that everyone forgets (including me).

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:23 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <A3B236A9-A469-4493-AE7E-0195E1F7F2CD@getmailspring.com>

---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68

On Sat, May 23, 2020 at 10:39 PM Cole Poirier <colepoirier@gmail.com> wrote:
>
> On May 23 2020, at 1:59 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> > soc.fu they are now common base classes.  the code is exactly the
> > same, it
> > is just split.
>
> I tried fixing this the naive way, by just substituting CommonInput
> stageStage for LogicalInputStage

why?

look at the class:

class LogicalInputStage(CommonInputStage):
    def __init__(self, pspec):
        super().__init__(pspec, "input")   <---- must be initialised
with an argument, "input"

    def ispec(self):
        return LogicalInputData(self.pspec)   <--- CommonInputStage
does not have this

    def ospec(self):
        return LogicalInputData(self.pspec)   <---- CommonInputStage
does not have this

    def elaborate(self, platform):
        m = super().elaborate(platform) # covers A-invert, carry, excludes SO
        comb = m.d.comb
        ctx = self.i.ctx

        # operand b
        comb += self.o.b.eq(self.i.b)    <----   CommonInputStage does
not do this

        return m

so what you are trying to do is guaranteed to fail, on four separate counts.

* no initialisation of CommonInputStage 1st parameter
* no ispec
* no ospec
* parameter B will not be copied over

so, don't do that.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Cole Poirier @ 2020-05-23 22:23 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDyi+M8bMxHfOTvpCN+5Xto3hSsRsUucHJqoHLG_gHtTCQ@mail.gmail.com>

On May 23 2020, at 3:14 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> On Sat, May 23, 2020 at 11:08 PM Cesar Strauss <cestrauss@gmail.com> wrote:
>> 
>> On 05/23/2020 17:57, Luke Kenneth Casson Leighton escreveu:
>> > it is 3am in brazil so Cesar will not be up, write on that
>> bugreport when
>> > you start and finish ok?
>> 
>> Something must have gone wrong somewhere...
>> 
>> It was only around 18:00 here, when you wrote that, not 03:00.
>> 
>> I'm on UTC-03:00.
> 
> ah!  i thought UTC +3, sorry!
> 
> ok Cole, let Cesar do the zero_imm unit test.
> 
> let me think what else to do.
> 
> l.

Will do! I'll await your directions.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Cole Poirier @ 2020-05-23 22:20 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDzhTY4EyU+T1nSiEM96DeQQ7e9WvAOiJtaepO7LtDgSqg@mail.gmail.com>

On May 23 2020, at 3:17 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:

> python3 fu/cr/test/test_pipe_caller.py

fu/logical/test/test_pipe_caller.py:

``
Traceback (most recent call last):
  File "test/test_pipe_caller.py", line 14, in <module>
    from soc.fu.logical.pipeline import LogicalBasePipe
  File "/home/colepoirier/src/soc/src/soc/fu/logical/pipeline.py", line
3, in <module>
    from soc.fu.logical.input_stage import LogicalInputStage
ModuleNotFoundError: No module named 'soc.fu.logical.input_stage'
```

Sorry I thought this was clear from: "Do I have to add something from
fu/logical/logical_input_record.py, or
add something else in order to use CommonInputStage properly?" I'll be
more explicit in the future.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:18 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDzhTY4EyU+T1nSiEM96DeQQ7e9WvAOiJtaepO7LtDgSqg@mail.gmail.com>

python3 fu/shift_rot/test/test_pipe_caller.py

succeeds

(am i giving the clear message that the information "python
test_pipe_caller.py" is not enough, yet? :) )

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:17 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDx7X+V3svfLyGommFE9kZUw+8oLsoG+EhWTD5qqEA_c8A@mail.gmail.com>

 python3 fu/cr/test/test_pipe_caller.py

succeeds.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:16 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDwrSREgayJQ0rHzAv45=uuQOMV_zXHWf5-JXvA61K8QUA@mail.gmail.com>

$
python3 fu/alu/test/test_pipe_caller.py

succeeds.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:16 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDyi+M8bMxHfOTvpCN+5Xto3hSsRsUucHJqoHLG_gHtTCQ@mail.gmail.com>

$ python3 fu/logical/test/test_pipe_caller.py

succeeds.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:15 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <A3B236A9-A469-4493-AE7E-0195E1F7F2CD@getmailspring.com>

On Sat, May 23, 2020 at 10:39 PM Cole Poirier <colepoirier@gmail.com> wrote:
>
> On May 23 2020, at 1:59 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> > soc.fu they are now common base classes.  the code is exactly the
> > same, it
> > is just split.
>
> I tried fixing this the naive way, by just substituting CommonInput
> stageStage for LogicalInputStage but this results in the following error:
>
> ```
> File "test_pipe_caller.py", line 193, in run_all

ok because you are running from "cd x.y.z" and then doing "python
./test_pipe_caller.py" i cannot tell which one of EIGHT
test_pipe_caller.py you are running.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Luke Kenneth Casson Leighton @ 2020-05-23 22:14 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <16cb4531-b727-dd88-b434-1c72cdb593d9@gmail.com>

On Sat, May 23, 2020 at 11:08 PM Cesar Strauss <cestrauss@gmail.com> wrote:
>
> On 05/23/2020 17:57, Luke Kenneth Casson Leighton escreveu:
> > it is 3am in brazil so Cesar will not be up, write on that bugreport when
> > you start and finish ok?
>
> Something must have gone wrong somewhere...
>
> It was only around 18:00 here, when you wrote that, not 03:00.
>
> I'm on UTC-03:00.

ah!  i thought UTC +3, sorry!

ok Cole, let Cesar do the zero_imm unit test.

let me think what else to do.

l.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 23may2020
From: Cesar Strauss @ 2020-05-23 22:08 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <CAPweEDzcvyqr-25ctDUB38zkDtjXMWX9xErAh8U77QrdyuyXzA@mail.gmail.com>

On 05/23/2020 17:57, Luke Kenneth Casson Leighton escreveu:
> it is 3am in brazil so Cesar will not be up, write on that bugreport when
> you start and finish ok?

Something must have gone wrong somewhere...

It was only around 18:00 here, when you wrote that, not 03:00.

I'm on UTC-03:00.

Try:

$ TZ='America/Sao_Paulo' date

or, do "date -u" and subtract 3 hours.

Cheers,

Cesar

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

page:   latest

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git