Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM
@ 2020-03-27  9:50 bugzilla-daemon
  2020-03-27 10:44 ` [libre-riscv-dev] [Bug 268] " bugzilla-daemon
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: bugzilla-daemon @ 2020-03-27  9:50 UTC (permalink / raw)
  To: libre-riscv-dev

http://bugs.libre-riscv.org/show_bug.cgi?id=268

            Bug ID: 268
           Summary: nmigen does not seem to support write-through SRAM
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: lkcl@lkcl.net
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

http://lists.libre-riscv.org/pipermail/libre-riscv-dev/2020-March/005453.html

we would like to have write-through capability in nmigen Memory.  when
one write-port writes, a read-port *in the same major cycle* is capable
of receiving that same data.

Staf mentions that the SRAM that he is doing makes that data available
on the *falling* edge (not on the exact same cycle).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [libre-riscv-dev] [Bug 268] nmigen does not seem to support write-through SRAM
  2020-03-27  9:50 [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM bugzilla-daemon
@ 2020-03-27 10:44 ` " bugzilla-daemon
  2020-03-27 10:55 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2020-03-27 10:44 UTC (permalink / raw)
  To: libre-riscv-dev

http://bugs.libre-riscv.org/show_bug.cgi?id=268

Staf Verhaegen <staf@fibraservi.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |staf@fibraservi.eu

--- Comment #1 from Staf Verhaegen <staf@fibraservi.eu> ---
I may have overlooked something and write-through may actually be implemented.
I think the trick is to have both a read and a write port; have these port
share the same address signal and also do a read when you do a write (e.g. have
transparent read port which make the read port always enabled).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [libre-riscv-dev] [Bug 268] nmigen does not seem to support write-through SRAM
  2020-03-27  9:50 [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM bugzilla-daemon
  2020-03-27 10:44 ` [libre-riscv-dev] [Bug 268] " bugzilla-daemon
@ 2020-03-27 10:55 ` bugzilla-daemon
  2020-03-27 13:45 ` bugzilla-daemon
  2020-03-27 16:05 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2020-03-27 10:55 UTC (permalink / raw)
  To: libre-riscv-dev

http://bugs.libre-riscv.org/show_bug.cgi?id=268

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |programmerjake@gmail.com

--- Comment #2 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
i think this was the basis of a unit test that jacob wrote, and he found that
there was a definite bug in the nmigen Simulation.  i believe however it
was a 2R1W arrangement.  jacob can you remember?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [libre-riscv-dev] [Bug 268] nmigen does not seem to support write-through SRAM
  2020-03-27  9:50 [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM bugzilla-daemon
  2020-03-27 10:44 ` [libre-riscv-dev] [Bug 268] " bugzilla-daemon
  2020-03-27 10:55 ` bugzilla-daemon
@ 2020-03-27 13:45 ` bugzilla-daemon
  2020-03-27 16:05 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2020-03-27 13:45 UTC (permalink / raw)
  To: libre-riscv-dev

http://bugs.libre-riscv.org/show_bug.cgi?id=268

--- Comment #3 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #2)
> i think this was the basis of a unit test that jacob wrote, and he found that
> there was a definite bug in the nmigen Simulation.  i believe however it
> was a 2R1W arrangement.  jacob can you remember?

Found it:
https://salsa.debian.org/Kazan-team/simple-barrel-processor/-/blob/391d95f30bd99e37236af8fb95565809b7230e29/test/test_mem.py

nmigen bug:
https://github.com/m-labs/nmigen/issues/47

Turned out that write conflicts weren't implemented as advertised, the buggy
feature (write port priority) was later removed:
https://github.com/m-labs/nmigen/commit/a02e3750bfeba44bcaad4c5de8d9eb0ef055d9c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [libre-riscv-dev] [Bug 268] nmigen does not seem to support write-through SRAM
  2020-03-27  9:50 [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM bugzilla-daemon
                   ` (2 preceding siblings ...)
  2020-03-27 13:45 ` bugzilla-daemon
@ 2020-03-27 16:05 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2020-03-27 16:05 UTC (permalink / raw)
  To: libre-riscv-dev

http://bugs.libre-riscv.org/show_bug.cgi?id=268

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
okaaay so that's write-port *priority*, not the same thing as write-*through*
capability.  you've got a (similar?) unit test kicking around, would you be ok
writing a similar one that checks if what is written can be read on the same
clock cycle?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27  9:50 [libre-riscv-dev] [Bug 268] New: nmigen does not seem to support write-through SRAM bugzilla-daemon
2020-03-27 10:44 ` [libre-riscv-dev] [Bug 268] " bugzilla-daemon
2020-03-27 10:55 ` bugzilla-daemon
2020-03-27 13:45 ` bugzilla-daemon
2020-03-27 16:05 ` bugzilla-daemon

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git