Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* Re: [libre-riscv-dev] daily kan-ban update 04jun2020
From: Cole Poirier @ 2020-06-04 22:28 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDzHERzHaawmeEui+jtuL_MLWg=raBgix5PCco+zS3gtdQ@mail.gmail.com>

On Jun 4 2020, at 5:10 am, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> yesterday:
> 
> * brief review of Cole's TRAP pipeline work (looks good, more comments added)

Thanks Luke, it's really helping me get work done and make progress each
day, and hopefully being able to do so a bit more independently than
last week.

Today:

Review Luke's comments and TODOs in TRAP pipeline, implement required changes.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-04 22:41 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #35 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #34)
> > go MSB -> LSB order, python is LSB->MSB order
> 
> sorry, that should be "python is LSB->MSB+1" order.

I think everything has been brought into line with your suggestions. Please
take a look and let me know if I've made a mistake, I'm specifically not
confident about my putting 'comb += nia_o.data.eq(br_ext(a_i[2:]))' on line
193, in OP_MFMSR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  0:32 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #36 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
 153                 with m.If(L):
 154                     comb += msr_o[MSR_EE].eq(msr_i[MSR_EE])
 155                     comb += msr_o[MSR_RI].eq(msr_i[MSR_RI])
 156 

look again at the VHDL. it inputs from c_in.  we assigned a_i to that.

here instead the copy is ciming from the incoming msr (msr_i).  clearly thus is
wrong.

line by line.

compare, literally, by putting two fingers pointing one at the VHDL and the
other at the nmigen code, like you are 5 years old learning to read, if you
have to!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  0:35 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #37 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
 197                 with m.If(a[MSR_PR]):
 198                         msr_o[MSR_EE].eq(1)
 199                         msr_o[MSR_IR].eq(1)

bug.  line 187 says "b_in" doesn't it? so why is a (a variable that does not
exist) being tested at line 197?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  1:06 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #38 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
i'm looking at the 3.0B pseudocode for OP_SC and going "hmmm".

SC-Form

* sc LEV

    SRR0 <-iea CIA + 4
    SRR1[33:36] <- 0
    SRR1[42:47] <- 0
    SRR1[0:32]  <- MSR[0:32] 
    SRR1[37:41] <- MSR[37:41]
    SRR1[48:63] <- MSR[48:63]
    MSR <- new_value 
    NIA <- 0x0000_0000_0000_0C00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  1:09 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #39 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Luke Kenneth Casson Leighton from comment #38)
> i'm looking at the 3.0B pseudocode for OP_SC and going "hmmm".
> 
> SC-Form
> 
> * sc LEV
> 
>     SRR0 <-iea CIA + 4

looking at what OP_TRAP does i think we need these 2 extra lines in OP_ SC:

      comb += srr0_o.data.eq(cia_i+4)   # old PC
      comb += srr0_o.ok.eq(1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  1:25 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #40 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
OP_RFID POWER9 3.0B pseudocode also has this:

    NIA <-iea SRR0[0:61] || 0b00

oooooo ngggh ok.  so in microwatt they are inputting SRR0 from a_in, and SRR1
from b_in.

we are not going to do that.

so in these lines 193 to 197:

 193                 comb += nia_o.data.eq(br_ext(a_i[2:]))
 194                 comb += nia_o.ok.eq(1)
 195                 for stt, end in [(0,16), (22, 27), (31, 64)]:
 196                     comb += msr_o.data[stt:end].eq(b_i[stt:end])
 197                 with m.If(a[MSR_PR]):

substitute srr0_i for a_i (and a at line 197) and srr1_i for b_i

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] publish crowdsupply update ourselves
From: Jacob Lifshay @ 2020-06-05  1:37 UTC (permalink / raw)
  To: Libre-RISCV General Development

since crowdsupply is taking such a long time (about 3mo, I think), I think
we should just publish the last update ourselves, otherwise it will be waay
out of date by the time it's finally published.

We should probably also set up an announcements mailing list such that we
can just email everyone on it, and, since we control it, we won't have to
wait for crowdsupply or someone else.

What do the rest of you think?

Jacob
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] publish crowdsupply update ourselves
From: Yehowshua @ 2020-06-05  1:43 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAC2bXD7ssp5SW0afWtXrFb5AbSvgJe0cVafG-M5NqFpwpsDUGg@mail.gmail.com>

Lets wait for crowd supply.

No rush right now. MHO

Yehowshua

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] publish crowdsupply update ourselves
From: Luke Kenneth Casson Leighton @ 2020-06-05  1:54 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAC2bXD7ssp5SW0afWtXrFb5AbSvgJe0cVafG-M5NqFpwpsDUGg@mail.gmail.com>

On Friday, June 5, 2020, Jacob Lifshay <programmerjake@gmail.com> wrote:

> since crowdsupply is taking such a long time (about 3mo, I think), I think
> we should just publish the last update ourselves, otherwise it will be waay
> out of date by the time it's finally published.
>
> We should probably also set up an announcements mailing list such that we
> can just email everyone on it, and, since we control it, we won't have to
> wait for crowdsupply or someone else.
>
> What do the rest of you think?


they reach far more people, with a much greater impact.

it is a very exclusive platform.

to build the same mailing list with the same reach would require us to hire
and create a marketing and PR team.

even large well established innovative companies do not do that.

what do they do?

use a crowdfunding platform.

i feel it is worth continuing to be patient with them, given the longterm
support they've shown for so many years.

l.



-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] publish crowdsupply update ourselves
From: Jacob Lifshay @ 2020-06-05  2:06 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <CAPweEDyxMqZuxXs_H_YzirB3RY6St8orZ-xrx4+_W+8PNLBSvg@mail.gmail.com>

On Thu, Jun 4, 2020, 18:54 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
wrote:

> On Friday, June 5, 2020, Jacob Lifshay <programmerjake@gmail.com> wrote:
>
> > since crowdsupply is taking such a long time (about 3mo, I think), I
> think
> > we should just publish the last update ourselves, otherwise it will be
> waay
> > out of date by the time it's finally published.
> >
> > We should probably also set up an announcements mailing list such that we
> > can just email everyone on it, and, since we control it, we won't have to
> > wait for crowdsupply or someone else.
> >
> > What do the rest of you think?
>
>
> they reach far more people, with a much greater impact.
>
> it is a very exclusive platform.
>
> to build the same mailing list with the same reach would require us to hire
> and create a marketing and PR team.
>

Ok, yeah, that's pretty impractical.

>
> even large well established innovative companies do not do that.
>
> what do they do?
>
> use a crowdfunding platform.
>
> i feel it is worth continuing to be patient with them, given the longterm
> support they've shown for so many years.
>

Yeah, ok. though we should at least send them another reminder email.

Jacob
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  2:13 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #41 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/decoder/power_decoder2.py;hb=HEAD

for OP_SC, OP_RFID and OP_TRAP we need to set the fast spr fields in DecodeA,
DecodeB and so on, so that the fields are correctly set.

this may involve the CSV files, putting the information there.

example: OP_TRAP needs to output SRR0, therefore DecodeOut needs to set
fast_out to SRR0 when the opcode is OP_TRAP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  2:34 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #42 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
from microwatt decode1.vhdl

elsif v.decode.insn_type = OP_RFID then
    report "PPC RFID";
    v.ispr1 := fast_spr_num(SPR_SRR0);
    v.ispr2 := fast_spr_num(SPR_SRR1);
end if;

that's what needs to go in PowerDecode2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  3:37 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #43 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Luke Kenneth Casson Leighton from comment #42)
> from microwatt decode1.vhdl
> 
> elsif v.decode.insn_type = OP_RFID then
>     report "PPC RFID";
>     v.ispr1 := fast_spr_num(SPR_SRR0);
>     v.ispr2 := fast_spr_num(SPR_SRR1);
> end if;
> 
> that's what needs to go in PowerDecode2

done.  DecodeOut --> SRR0, DecodeOut2 --> SRR1

so.

when the TRAP pipeline is called, SRR0 will go into spr1, SRR1 will go into
spr2.



--- a/src/soc/decoder/power_decoder2.py
+++ b/src/soc/decoder/power_decoder2.py
@@ -241,6 +241,12 @@ class DecodeOut(Elaboratable):
             with m.If(~self.dec.BO[2]): # 3.0B p38 BO2=0, use CTR reg
                 comb += self.fast_out.data.eq(FastRegs.CTR) # constant: CTR
                 comb += self.fast_out.ok.eq(1)
+
+        # RFID 1st spr (fast)
+        with m.If(op.internal_op == InternalOp.OP_RFID):
+                comb += self.fast_out.data.eq(FastRegs.SRR0) # constant: SRR0
+                comb += self.fast_out.ok.eq(1)
+
         return m


@@ -275,6 +281,11 @@ class DecodeOut2(Elaboratable):
                 comb += self.fast_out.data.eq(FastRegs.LR) # constant: LR
                 comb += self.fast_out.ok.eq(1)

+        # RFID 2nd spr (fast)
+        with m.If(op.internal_op == InternalOp.OP_RFID):
+                comb += self.fast_out.data.eq(FastRegs.SRR1) # constant: SRR1
+                comb += self.fast_out.ok.eq(1)
+
         return m

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  3:52 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #44 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
i added a version of msr_copy, and this version it has the option to
zero the destination msr or not.  so unlike in the comments, it *can*
be used in OP_RFID.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 363] inconsistency between isel and mfcr and crand unit test on bit-ordering of CR
From: bugzilla-daemon @ 2020-06-05  3:55 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-363-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=363

--- Comment #3 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
michael, i kinda need your help on this one.  soc/simple/test/test_core.py
is showing reg-reordering.  this *might* be possible to "fix" in VirtualRegPort
by inverting the concatenation order of the 8 registers to create the full
32-bit, rather than doing this in power_regspec_map.py:

        if name == 'full_cr': # full CR
            return e.read_cr_whole, 0b11111111, 0b11111111
        if name == 'cr_a': # CR A
            return e.read_cr1.ok, 1<<(7-e.read_cr1.data),
1<<(7-e.write_cr.data)

however i honestly have no idea what i'm doing, and would continue to
experiment
for several days, inverting bits until something worked.

or, it could just be that the CR regfile is not getting written to properl
(as in, the write-enable signals are not properly getting through).
i'll investigate that angle.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 363] inconsistency between isel and mfcr and crand unit test on bit-ordering of CR
From: bugzilla-daemon @ 2020-06-05  3:55 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-363-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=363

Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lkcl@lkcl.net               |mtnolan2640@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 348] POWER9 SPR pipeline needed
From: bugzilla-daemon @ 2020-06-05  4:02 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-348-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=348

--- Comment #6 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
TODO: MFSPR/MTSPR need fast-reg decoding in PowerDecoder2 DecodeA and DecodeOut

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05  4:19 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #45 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
 184                     with m.If(a[MSR_PR]):
 185                             msr_o[MSR_EE].eq(1)
 186                             msr_o[MSR_IR].eq(1)
 187                             msr_o[MSR_DR].eq(1)

should be msr_o.data

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 363] inconsistency between isel and mfcr and crand unit test on bit-ordering of CR
From: bugzilla-daemon @ 2020-06-05 13:39 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-363-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=363

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
p34 section 2.4.1 of spec

Instructions are provided to perform logical operations on individual CR bits
and to test individual CR bits.
For all fixed-point instructions in which Rc=1, and for addic., andi., and
andis., the first three bits of CR Field 0 (bits 32:34 of the Condition
Register) are set by signed comparison of the result to zero, and the fourth
bit of CR Field 0 (bit 35 of the Condition Register) is copied from the SO
field of the XER. “Result” here refers to the entire 64-bit value placed into
the target register in 64-bit mode, and to bits 32:63 of the 64-bit value
placed into the target register in 32-bit mode.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 363] inconsistency between isel and mfcr and crand unit test on bit-ordering of CR
From: bugzilla-daemon @ 2020-06-05 13:58 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-363-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=363

--- Comment #5 from Michael Nolan <mtnolan2640@gmail.com> ---
Luke - I'll investigate this at some point this weekend. I'm a little busy so I
don't know exactly when

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05 14:16 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #46 from Cole Poirier <colepoirier@gmail.com> ---
Ok. I think now the nmigen should match the microwatt VHDL, however, there may
be small errors as you made some modifications but left others for me to fix,
and I got confused about some of your comments re a_i, b_i, but I did my best
to interpret your comments while reading, line-by-line the vhdl from the
comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05 15:12 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #47 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
this is going to be a mess.

mtmsr pseudocode:

if L = 0 then
    MSR48 <- (RS)48 | (RS)49
    MSR58 <- ((RS)58 | (RS)49)
        & ¬(MSR41 & MSR3 & (¬(RS)49))
    MSR59 <- ((RS)59 | (RS)49)
        & ¬(MSR41 & MSR3 & (¬(RS)49))
    MSR32:40 42:47 49:50 52:57 60:62
       (RS)32:40 42:47 49:50 52:57 60:62
else:
    MSR48 62 <- (RS)48 62

i forgot to add the pseudocode from mtmsr and mfmsr to the isa markdown
files.  the above is note-form from the 3.0B PDF

mfmsr:

RT <- MSR

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05 15:21 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #48 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
just did some updates/comments so we can see what's going on, in english.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline
From: bugzilla-daemon @ 2020-06-05 15:33 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-325-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #49 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #48)
> just did some updates/comments so we can see what's going on, in english.

Appreciated, significantly clearer than it was before. Looking at the code, it
seems to be in line with the VHDL in the comments. One question, what does '#
XXX which bit?' on line 147 refer to?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

page:   latest

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git