* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 14:18 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
Michael Nolan <mtnolan2640@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtnolan2640@gmail.com
--- Comment #17 from Michael Nolan <mtnolan2640@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #16)
> (In reply to Cole Poirier from comment #15)
>
> > Spent an hour trying to sense of this but I think my brain has given up for
> > the day. Will make a fresh effort tomorrow.
>
> did a bit of a reorg. i think we need to look at how proof_fu.py works.
> the use of "Initial()" may be crucial.
It is. From my experience doing formal stuff in verilog, if you use $past()
without making sure the module is properly reset, the proof engine will make up
values for the signals before the proof even starts. Making sure you have a
reset for the first cycle of the proof, and not examining any Past() signals on
that cycle will avoid this.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 216] LOAD STORE buffer needed
From: bugzilla-daemon @ 2020-05-28 13:26 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-216-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=216
--- Comment #50 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Tobias Platen from comment #49)
> I've added a unittest for DataMerger and I get the following import error:
> cannot import name 'treereduce' from 'nmutil.util'
> I git pulled the nmutil repo but there were no changes.
see earlier comment.
"this is why i said to use treereduce. or, actually, now you can import
ortreereduce, from soc.regfile.regfile."
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 216] LOAD STORE buffer needed
From: bugzilla-daemon @ 2020-05-28 13:07 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-216-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=216
--- Comment #49 from Tobias Platen <libre-soc@platen-software.de> ---
I've added a unittest for DataMerger and I get the following import error:
cannot import name 'treereduce' from 'nmutil.util'
I git pulled the nmutil repo but there were no changes.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 216] LOAD STORE buffer needed
From: bugzilla-daemon @ 2020-05-28 12:38 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-216-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=216
--- Comment #48 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
----------
hmmm...
l = []
for j in range(self.array_size):
select = self.addr_match_i[idx][j] & valid
l.append(Mux(select, self.data_i[j], 0))
self.data_o.eq(ortreereduce(l))
this would be better / clearer:
with m.If(valid):
l = []
for j in range(self.array_size):
select = self.addr_match_i[idx][j]
l.append(Mux(select, self.data_i[j], 0))
self.data_o.eq(ortreereduce(l))
-----
return m is missing.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 216] LOAD STORE buffer needed
From: bugzilla-daemon @ 2020-05-28 12:35 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-216-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=216
--- Comment #47 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
hi tobias, saw the latest commit, getting there.
------
comb, sync = m.d.comb, m.d.sync
sync is not needed
-------
#(1) pick a row
m.submodules.pick = pick = PriorityEncoder(self.array_size)
for j in range(self.array_size):
with m.If(self.addr_match_i[j].bool()):
pick.i.eq(pick.i||(1<<j))
again: as previous comment, this is not python (and the comb += is missing
at the front, which means that the nmigen AST is discarded, doing nothing)
everything is parallel hardware, not sequential python. the nmigen AST
captures that parallel hardware definition.
so, here, we want each bit of the PriorityPicker input to connect to one
bit of the test of whether a line in addr_match_i is empty/non-empty.
therefore, we need to assign addr_match_i[i].bool() to each bit of pick.i:
# assign each priority-picker input bit the test whether the
# address match line is non-empty.
for j in range(self.array_size):
comb += pick.i[j].eq(self.addr_match_i[j].bool())
simple as that.
-------
self.data_o.eq(ortreereduce(l))
import is missing.
-----
fix those and it'll be time to move on to a unit test.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] Fwd: power-gem5
From: lkcl . @ 2020-05-28 12:02 UTC (permalink / raw)
To: openpower-hdl-cores, Libre-RISCV General Development
In-Reply-To: <CADZoGRXr9KVcQkGw5RBp1FND9y2+OK2aoDoFUxA=prkY9cERGg@mail.gmail.com>
hi folks, i just received this from the IBM team behind the power-gem5
port (which hugh kindly alerted me to) - as you can see below they
managed to track down the memory leak. this means that the power-gem5
simulator, which is cycle-accurate, is capable of booting a linux
kernel with an initramfs containing busybox and a hello-world program.
yes they implemented a RADIX MMU including hypervisor mode i believe.
linux kernel device-driver interrupts are working however according to
the last presentation on the topic, at present these are done using
polling.
l.
---------- Forwarded message ---------
From: Basavaraj Talawar
Luke,
A few weeks back the team were able to root-cause and fix the memory
leaks that originated from the address translation code. The changes
have been pushed to the 'gem5-experimental' branch of our repository.
https://github.com/power-gem5/gem5
Here's a link to the commit that fixes this.
https://github.com/power-gem5/gem5/commit/cae53531103ebc5bccddf874db85f2659b64000a
Memory usage now stays under 500MB.
BT.
On Mon, Mar 16, 2020 at 2:41 PM lkcl . <luke.leighton@gmail.com> wrote:
>
> i can confirm that using gcc/g++ version 8 still has the same massive
> memory leaks. despite this, it is a huge achievement.
> best,
> l.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 350] LDSTCompUnit also needs to support zeroing on RA
From: bugzilla-daemon @ 2020-05-28 10:44 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-350-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=350
Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=356
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-28 10:44 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=336
Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=356
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 334] POWER decode A=zero needs to be set as a flag in Execute1Type
From: bugzilla-daemon @ 2020-05-28 10:44 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-334-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=334
Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=356
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 356] fu POWER9 pipeline unit tests need to test RA=0
From: bugzilla-daemon @ 2020-05-28 10:44 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-356-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=356
Luke Kenneth Casson Leighton <lkcl@lkcl.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=334,
| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=336,
| |https://bugs.libre-soc.org/
| |show_bug.cgi?id=350
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 356] New: fu POWER9 pipeline unit tests need to test RA=0
From: bugzilla-daemon @ 2020-05-28 10:43 UTC (permalink / raw)
To: libre-riscv-dev
https://bugs.libre-soc.org/show_bug.cgi?id=356
Bug ID: 356
Summary: fu POWER9 pipeline unit tests need to test RA=0
Product: Libre-SOC's first SoC
Version: unspecified
Hardware: PC
OS: Mac OS
Status: CONFIRMED
Severity: enhancement
Priority: ---
Component: Source Code
Assignee: lkcl@lkcl.net
Reporter: lkcl@lkcl.net
CC: libre-riscv-dev@lists.libre-riscv.org
NLnet milestone: ---
some of the instructions act differently when RA=0 (this means pass in a
zero-immediate to RA rather than the contents of register 0). tests
for both zero-immediate-A and also for actually ensuring that RA=0 reads
register 0 are needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 10:18 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #16 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #15)
> Spent an hour trying to sense of this but I think my brain has given up for
> the day. Will make a fresh effort tomorrow.
did a bit of a reorg. i think we need to look at how proof_fu.py works.
the use of "Initial()" may be crucial.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 324] create POWER9 DIV pipeline
From: bugzilla-daemon @ 2020-05-28 10:03 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-324-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=324
--- Comment #7 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Jacob Lifshay from comment #6)
> I added a Rust model for the div and rem instructions as well as converted
> the output format to JSON since that's waay easier to ingest than the custom
> output format I had before.
:)
> This should make it easier to copy the behavior of POWER9 in the nmigen div
> pipeline.
ah fantastic. yes, looking at microwatt, the synthesis of all the various
options is quite obtuse (and brilliant).
i've found it is essential to have some form of guide in a familiar language.
it's really useful that these are also binary-executable on native POWER9
as well as really clear documented actual implementations.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 324] create POWER9 DIV pipeline
From: bugzilla-daemon @ 2020-05-28 6:51 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-324-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=324
Jacob Lifshay <programmerjake@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |IN_PROGRESS
--- Comment #6 from Jacob Lifshay <programmerjake@gmail.com> ---
I added a Rust model for the div and rem instructions as well as converted the
output format to JSON since that's waay easier to ingest than the custom output
format I had before. The model matches the native POWER9 instructions for all
the cases I tested.
I also added conditional compilation code that allows running just the model on
any computer rather than just on POWER9:
Run it with:
cargo run --no-default-features
Model functions:
https://salsa.debian.org/Kazan-team/power-instruction-analyzer/-/blob/master/src/instr_models.rs
This should make it easier to copy the behavior of POWER9 in the nmigen div
pipeline.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 2:59 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #15 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Cole Poirier from comment #14)
> (In reply to Luke Kenneth Casson Leighton from comment #13)
> > no idea.
> >
> > first thing though: it is unsafe to mix python parameters that change the
> > entire behaviour of the module.
> >
> > i suggest starting with two utterly different proofs, divided and isolated
> > with "if self.writethru". yes NOT m.If because python parameters != nmigen
> > AST.A
> >
> > then, to do a 4 way (dual nested) set of m.If on ren and wen.
> >
> > then, in EACH quadrant, do completely separate assertions.
> >
> > but before making those assertions, write out in words the expected
> > behaviour when the 4 way truth table of wen and ren occurs.
>
> Ah yes that makes sense. That is how the module I'm trying to verify is
> written after all. Thanks for your guidance and helpful redirection on this.
> I'll work through the 4 way truth table with expected behavior in words then
> report back.
Spent an hour trying to sense of this but I think my brain has given up for the
day. Will make a fresh effort tomorrow.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 1:50 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #14 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #13)
> no idea.
>
> first thing though: it is unsafe to mix python parameters that change the
> entire behaviour of the module.
>
> i suggest starting with two utterly different proofs, divided and isolated
> with "if self.writethru". yes NOT m.If because python parameters != nmigen
> AST.A
>
> then, to do a 4 way (dual nested) set of m.If on ren and wen.
>
> then, in EACH quadrant, do completely separate assertions.
>
> but before making those assertions, write out in words the expected
> behaviour when the 4 way truth table of wen and ren occurs.
Ah yes that makes sense. That is how the module I'm trying to verify is written
after all. Thanks for your guidance and helpful redirection on this. I'll work
through the 4 way truth table with expected behavior in words then report back.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 1:33 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #13 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
no idea.
first thing though: it is unsafe to mix python parameters that change the
entire behaviour of the module.
i suggest starting with two utterly different proofs, divided and isolated with
"if self.writethru". yes NOT m.If because python parameters != nmigen AST.A
then, to do a 4 way (dual nested) set of m.If on ren and wen.
then, in EACH quadrant, do completely separate assertions.
but before making those assertions, write out in words the expected behaviour
when the 4 way truth table of wen and ren occurs.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-28 1:18 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #12 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #11)
> (In reply to Cole Poirier from comment #10)
> > Tests now actually run, so I pushed a new commit. In order to formally
> > verify class Register(), I think I've done most of it, but there's a part of
> > the class's elaborate function that uses sync instead of comb, and I'm not
> > sure how to do this in proof form.
>
> one way is to use Past()
Sorry for the delay. I did a git pull and added an Assert using Past() but my
proof is still failing. I pushed my commit. Can you take a look when you can to
help me identify where I've erred?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 323] create POWER9 MUL pipeline
From: bugzilla-daemon @ 2020-05-27 22:21 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-323-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=323
--- Comment #3 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
from microwatt: how to set up the inputs to the mul pipeline. this can go in
main_stage.py when calling the mul unit:
if e_in.is_32bit = '1' then
if e_in.is_signed = '1' then
x_to_multiply.data1 <= (others => a_in(31));
x_to_multiply.data1(31 downto 0) <= a_in(31 downto 0);
x_to_multiply.data2 <= (others => b_in(31));
x_to_multiply.data2(31 downto 0) <= b_in(31 downto 0);
else
x_to_multiply.data1 <= '0' & x"00000000" & a_in(31 downto 0);
x_to_multiply.data2 <= '0' & x"00000000" & b_in(31 downto 0);
else
if e_in.is_signed = '1' then
x_to_multiply.data1 <= a_in(63) & a_in;
x_to_multiply.data2 <= b_in(63) & b_in;
else
x_to_multiply.data1 <= '0' & a_in;
x_to_multiply.data2 <= '0' & b_in;
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* Re: [libre-riscv-dev] Power ISA v3.1 bug - parityw
From: Luke Kenneth Casson Leighton @ 2020-05-27 22:09 UTC (permalink / raw)
To: Libre-RISCV General Development; +Cc: openpower-hdl-cores
In-Reply-To: <20200527214919.GA307798@thinks.paulus.ozlabs.org>
On Wednesday, May 27, 2020, Paul Mackerras <paulus@ozlabs.org> wrote:
>
> > The description of "least significant bit in each byte" leads me to
> believe
> > that RS[i%8 + 7] should really be RS[i*8+7]. This is also how it is
> > implemented in microwatt
>
> The IBM Power architects have confirmed that it should be
> multiplication rather than remainder, i.e. RS[i*8+7] as you suggest.
super. i can see from the revisions (3.0B -> 3.1B) that it was copied from
a divmod algorithm.
thanks paul.
l.
--
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* Re: [libre-riscv-dev] [OpenPOWER-HDL-Cores] Power ISA v3.1 bug - parityw
From: Paul Mackerras @ 2020-05-27 21:49 UTC (permalink / raw)
To: Michael Nolan; +Cc: openpower-hdl-cores, Libre-RISCV General Development
In-Reply-To: <48876f64-f3fa-c616-6710-ba773c89173c@gmail.com>
On Fri, May 15, 2020 at 11:07:12AM -0400, Michael Nolan wrote:
> Hello! I'm with the Libre-SOC team, and was working on testing our
> implementation of the parityw and parityd instructions when I came across
> the following bug in the specification. The specification describes prtyd as
> follows:
>
> s <- 0
>
> do i = 0 to 7
>
> s <- s (XOR) RS[i%8 + 7]
>
> RA <- 63'b0 || s
>
> The least significant bit in each byte of the contents of register RS is
> examined. If there is an odd number of one bits the value 1 is placed into
> register RA; otherwise the value 0 is placed into register RA.
>
>
>
> The description of "least significant bit in each byte" leads me to believe
> that RS[i%8 + 7] should really be RS[i*8+7]. This is also how it is
> implemented in microwatt
The IBM Power architects have confirmed that it should be
multiplication rather than remainder, i.e. RS[i*8+7] as you suggest.
Paul.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 355] game theory "state" packet engine needed
From: bugzilla-daemon @ 2020-05-27 21:42 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-355-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=355
--- Comment #1 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
some possible ideas which preserve the state/context:
* a ring buffer with the instruction, TB, DEC and other context as entries is
created. the index of the ring buffer entry is passed down the pipeline "ctx"
(context)
* TB, PC and DEC are passed into "ctx". as this is 3x 64 bit that is an awful
lot, it will be copied right the way through the pipelines (and not actually
change or be used).
* a separate instruction queue and a separate ring buffer for state.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 355] New: game theory "state" packet engine needed
From: bugzilla-daemon @ 2020-05-27 21:04 UTC (permalink / raw)
To: libre-riscv-dev
https://bugs.libre-soc.org/show_bug.cgi?id=355
Bug ID: 355
Summary: game theory "state" packet engine needed
Product: Libre-SOC's first SoC
Version: unspecified
Hardware: Other
OS: Linux
Status: CONFIRMED
Severity: enhancement
Priority: ---
Component: Source Code
Assignee: lkcl@lkcl.net
Reporter: lkcl@lkcl.net
CC: libre-riscv-dev@lists.libre-riscv.org
NLnet milestone: ---
it occurred to me that the branch system etc. is basically running game theory
(in hardware), running new "state" ahead.
the program counter, DEC SPR, and TB SPR, these all increment and need rollback
in a group. there may also be other pieces of state information involved.
my feeling is that we will need a ring buffer, associated with the instruction
queue (or actually part of it) that contains each advancement of that state,
and thus we can roll it back without losing anything.
perhaps it is as simple as adding DEC and TB to the Decode2ExecuteType data
structure?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-27 19:43 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #11 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #10)
> Tests now actually run, so I pushed a new commit. In order to formally
> verify class Register(), I think I've done most of it, but there's a part of
> the class's elaborate function that uses sync instead of comb, and I'm not
> sure how to do this in proof form.
one way is to use Past()
>
> ```
> def elaborate(self, platform):
> m = Module()
> self.reg = reg = Signal(self.width, name="reg")
>
> [snip..]
> # write ports, don't allow write to address 0 (ignore it)
> for wp in self._wrports:
> with m.If(wp.wen):
> m.d.sync += reg.eq(wp.data_i)
>
> return m
> ```
>
> Does the above prevent write to address 0, and if so how?
no. do git pull
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-27 19:25 UTC (permalink / raw)
To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>
https://bugs.libre-soc.org/show_bug.cgi?id=353
--- Comment #10 from Cole Poirier <colepoirier@gmail.com> ---
Tests now actually run, so I pushed a new commit. In order to formally verify
class Register(), I think I've done most of it, but there's a part of the
class's elaborate function that uses sync instead of comb, and I'm not sure how
to do this in proof form.
```
def elaborate(self, platform):
m = Module()
self.reg = reg = Signal(self.width, name="reg")
[snip..]
# write ports, don't allow write to address 0 (ignore it)
for wp in self._wrports:
with m.If(wp.wen):
m.d.sync += reg.eq(wp.data_i)
return m
```
Does the above prevent write to address 0, and if so how? because it doesn't
seem to do any conditional checking. Further, how would I integrate this in
order to finish the proof or register?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
^ permalink raw reply
page: next prev latest
Libre RISC-V Mailing list Archives (accessible via public-inbox)
Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev
Example config snippet for mirrors
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git