Libre RISC-V Mailing list Archives (accessible via public-inbox)
 help / color / Atom feed
* Re: [libre-riscv-dev] daily kan-ban update 25may2020
From: Luke Kenneth Casson Leighton @ 2020-05-25 22:45 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <EF27EE71-46C9-426B-93EC-A7DDC61E804E@getmailspring.com>

On Monday, May 25, 2020, Cole Poirier <colepoirier@gmail.com> wrote:

> On May 25 2020, at 2:35 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net>
> wrote:
> > in your wiki home page you will find a link to bugs assigned to you.  the
> > default action is basically "monitor and do that list".
>
> Thanks that makes it easy. I saw you assigned me 'Bug 337 - Convention
> for register outputs in *OutputData structures is to use "Data"', and
> looked at your comment. Is this simply reorg or is there something
> additional I should be aware of?


ah i think i kinda did that one yesterday.


>
> > one to add:
> >
> > if you can also find the "interfaces" issue, and assign it to
> > yourself, you
> > will see a list of interfaces in the last comment, including "serialized
> > irq" which you shouls find somewhere from raptor engineering.
> >
> > can you track the source code down, add them to the wiki  under the right
> > subdurectory (shakti mclass) and also crossreference them in the
> bugtracker?
>
>
> Are you referring to "Bug 304 - Define minimum viable interface set for
> 180nm ASIC", comment #6?


yes.


> ```
> Luke Kenneth Casson Leighton 2020-05-20 23:14:26 BST
>
> conversation notes from Tim (Raptor Engineering)
>
> priority:
>
> * 2x SPI master
> * 4x I2C master
> * 2x UART
> * 4x LPC master
> * EINT* Serialsed IRQ (LPC, from PCIe) - 15 or so IRQs, these are
> PC>PCIe>OpenPower mappings
>
> Quad SPI raptorengineering
> LPC bridge github raptorengineering
> ```
>
> I searched for "raptor serialized irq, and only found references to
> raptors lpc-spi-bridge-fpga gitlab repo. Is this what we need
> https://gitlab.raptorengineering.com/raptor-engineering-public/lpc-spi-
> bridge-fpga?


that sort of thing.

we need to find the full implementation, an actual serialized-irq master



> An in terms of adding the source code to the wiki,


> do you want me to
> just copy and paste the 1000+ line verilog file or files to the
> soc/libreriscv/shakti/m_class directory?


no!  a wiki is not a source code repository, it is for documentation



> Or do you want me to do
> something similar to what you did for sdram.mdwn in the same directory?


yes.


>
> ```
> # SDRAM
>
> * <https://bitbucket.org/casl/c-class/src/3fba75dfbd0c64815eb8ec6dc96566
> 6812c44bae/src/peripherals/sdram/?at=master>
> * <https://opencores.org/projects/sdr_ctrl>
> ```
>
> Cole
>
> _______________________________________________
> libre-riscv-dev mailing list
> libre-riscv-dev@lists.libre-riscv.org
> http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev
>


-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 337] Convention for register outputs in *OutputData structures is to use "Data"
From: bugzilla-daemon @ 2020-05-25 22:53 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-337-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=337

Cole Poirier <colepoirier@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colepoirier@gmail.com       |lkcl@lkcl.net

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-25 23:06 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

--- Comment #34 from Cesar Strauss <cestrauss@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #33)
> right.  so i've pushed another commit which shows where we would expect to
> put the inputs in (constructor).  rather than have them directly as arguments
> to op_sim(), all those arguments - a, b, op, inv_a, imm_ok, zero_a - they
> become the arguments to the constructor.
> 
> also expected_o should be in the constructor as well.

Implemented the issue_i/busy_o protocol check, for the moment.

Will add the above as I need them, incrementally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 25may2020
From: Cole Poirier @ 2020-05-25 23:22 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDzN43JyCZRuK20tqQtr2RRRJRQFdLRLPE6eb_-7ScB4JQ@mail.gmail.com>

May 25 2020, at 3:45 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> we need to find the full implementation, an actual serialized-irq master

After about 30 min of googling I've only been able to find the following
which I believe from the below copyright is what you're looking for?

```
$Id: serirq_host.v,v 1.2 2008-12-27 19:46:18 hharte Exp $   ////
////  serirq_host.v - SERIRQ Host Controller                      ////
////                                                              ////
////  This file is part of the Wishbone LPC Bridge project        ////
////  http://www.opencores.org/projects/wb_lpc/                   ////
////                                                              ////
////  Author:                                                     ////
////      - Howard M. Harte (hharte@opencores.org) 
```
https://opencores.org/websvn/filedetails?repname=wb_lpc&path=%2Fwb_lpc%2Ftrunk%2Frtl%2Fverilog%2Fserirq_host.v

Once you let me know if this is correct I'll add it to the wiki and
crossref with bug 304.

Aside from this, my only other active bug report is to do with fixing
one small thing in coriolis2 chroot setup script and documenting the
changes to the hdl_workflow on the wiki. Is there HDL work that I can
take on? Possibly some formal proofs that I could see if I can crack?

Cole


_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 25may2020
From: Luke Kenneth Casson Leighton @ 2020-05-25 23:40 UTC (permalink / raw)
  To: Libre-RISCV General Development
In-Reply-To: <8348DED5-B649-45F6-8258-EE8AD236E0F3@getmailspring.com>

On Tuesday, May 26, 2020, Cole Poirier <colepoirier@gmail.com> wrote:

> May 25 2020, at 3:45 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net>
> wrote:
> > we need to find the full implementation, an actual serialized-irq master
>
> After about 30 min of googling I've only been able to find the following
> which I believe from the below copyright is what you're looking for?
>
> ```
> $Id: serirq_host.v,v 1.2 2008-12-27 19:46:18 hharte Exp $   ////
> ////  serirq_host.v - SERIRQ Host Controller                      ////
> ////                                                              ////
> ////  This file is part of the Wishbone LPC Bridge project        ////
> ////  http://www.opencores.org/projects/wb_lpc/                   ////
> ////                                                              ////
> ////  Author:                                                     ////
> ////      - Howard M. Harte (hharte@opencores.org)
> ```
> https://opencores.org/websvn/filedetails?repname=wb_lpc&
> path=%2Fwb_lpc%2Ftrunk%2Frtl%2Fverilog%2Fserirq_host.v
>
> Once you let me know if this is correct I'll add it to the wiki and
> crossref with bug 304.


it looks like it.  we can ask Raptor Engineering.


>
> Aside from this, my only other active bug report is to do with fixing
> one small thing in coriolis2 chroot setup script and documenting the
> changes to the hdl_workflow on the wiki. Is there HDL work that I can
> take on?


yes.  the multiport Regfile one.
https://bugs.libre-soc.org/show_bug.cgi?id=351

 it should be simple to do, it is just to use Cat() on the 8 ports data.

however it should be done under a Mux which ensures only one reader/writer

i will write more in the bugreport.

this one is time sensitive.


> Possibly some formal proofs that I could see if I can crack?


actually one for Regfile and RegfileArray would be good.

if you can raise a bugreport about that?

l.



-- 
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-25 23:41 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

--- Comment #35 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cesar Strauss from comment #34)


> Implemented the issue_i/busy_o protocol check, for the moment.

i saw.  looks good.

> Will add the above as I need them, incrementally.

ok.

it will be fascinating to compare against the formal proof

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-25 23:55 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #1 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
ok so first derive from RegFileArray.

use the two parameters as follows:

* bitwidth: the TOTAL number of bits
* n_regs: the number of subdivisions of those bits.

therefore RegfileArray n_regs = nregs

however RegfileArray regwidth is bitwidth DIVIDED by n_regs.

then, in the constructor, add n_regs read ports and n_regs write ports to a
pair of lists.

you can see this being done in soc.regfile.regfiles here

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/regfile/regfiles.py;h=d6f3a8dd79930d1286c72a42328363d9b9b8e9f3;hb=HEAD#l42

except, that should be a for loop


next, we want an EXTRA read port and an extra write port.

this should, for data, instead of being only bitwidth/nregs wide, should
instead be the FULL bitwidth wide. 

however the enable lines should be nregs wide.

39         port = RecordObject([("ren", nregs),
  40                              ("data_o", bitwidth)],
  41                             name=name)

like that.


then, in the elaborate:

* if any of the "extra" port ren bits are set, the data is sent through the
corresponding *lower* indexed ports.

you see how that works?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] daily kan-ban update 25may2020
From: Cole Poirier @ 2020-05-26  0:11 UTC (permalink / raw)
  To: Libre-RISCV General Development; +Cc: Libre-RISCV General Development
In-Reply-To: <CAPweEDzYRzFXPVR5dNr2KCVbpvSbah3fC0Xn2sC1we_-bnFQ5w@mail.gmail.com>

On May 25 2020, at 4:40 pm, Luke Kenneth Casson Leighton <lkcl@lkcl.net> wrote:
> On Tuesday, May 26, 2020, Cole Poirier <colepoirier@gmail.com> wrote:
>> https://opencores.org/websvn/filedetails?repname=wb_lpc&
>> path=%2Fwb_lpc%2Ftrunk%2Frtl%2Fverilog%2Fserirq_host.v
>> 
>> Once you let me know if this is correct I'll add it to the wiki and
>> crossref with bug 304.
> 
> 
> it looks like it.  we can ask Raptor Engineering.

Ok. I'll make a note on bug 304 that you will ask Raptor engineering
about this document? Then after we have confirmed I'll add it to the
repo in our mdwn file format for referencing external resources, and
note on this on the bug report.

> yes.  the multiport Regfile one.
> https://bugs.libre-soc.org/show_bug.cgi?id=351
> 
> it should be simple to do, it is just to use Cat() on the 8 ports data.
> 
> however it should be done under a Mux which ensures only one reader/writer
> 
> i will write more in the bugreport.
> 
> this one is time sensitive.

Awesome! I'll start now.

>> Possibly some formal proofs that I could see if I can crack?
> 
> 
> actually one for Regfile and RegfileArray would be good.
> 
> if you can raise a bugreport about that?

Will do this now then start on the multiport regfile task.

Cole

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 353] New: formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-26  0:13 UTC (permalink / raw)
  To: libre-riscv-dev

https://bugs.libre-soc.org/show_bug.cgi?id=353

            Bug ID: 353
           Summary: formal proof of soc.regfile classes RegFile and
                    RegFileArray needed
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl@lkcl.net
          Reporter: colepoirier@gmail.com
                CC: libre-riscv-dev@lists.libre-riscv.org
   NLnet milestone: ---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 353] formal proof of soc.regfile classes RegFile and RegFileArray needed
From: bugzilla-daemon @ 2020-05-26  0:13 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-353-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=353

Cole Poirier <colepoirier@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lkcl@lkcl.net               |colepoirier@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  1:18 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #2 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=HEAD

saw this.


i think... actually... the list  of ports in the constructor, have to be done
manually, then those wired via a mux to the "real" ports

so a for loop adds RecordObjects

ren=1, data=bitwidth/nregs

then appends an *extra* on
ren=nregs, data=bitwidth


then in the constructor:

* test port[-1].ren == 0

* if zero then for all ports 0 to nregs, connect *internal* port to external
port

* else put bitwidth/nregs bits of port[-1].data onto port[loopindex].data and
also do same with enable bits.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  1:34 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #3 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #1)

Unfortunately I had quite a lot of difficulty trying to follow your
instructions. I was unable to determine what you were referring to in several
instances, and grepping for some of the terms used turned up no results in the
codebase. I went ahead and pushed my commit as soc/regfile/virtual_port.py, its
my best attempt at interpreting your instructions, but its god ugly and I felt
bad about committing such a weak skeleton, but remembered your earlier guidance
to push so it's easier to get help. Hopefully with some clarifying questions
below I'll be able to better learn to speak the language of the project :)

> ok so first derive from RegFileArray.

As in regfiles.py "class IntRegs(RegFileArray):"?

> use the two parameters as follows:

By 'the two parameters', do you mean inherited from RegFileArray self.width and
self.depth? Otherwise do you mean take the below two parameters as new
parameters in the __init__ of VirtualPort, like "def __init__(self, bitwidth,
n_regs):'? Also do I have to "super().__init__(m, n)" before assigning python
lists to self.w_ports and same for rd?

> * bitwidth: the TOTAL number of bits
> * n_regs: the number of subdivisions of those bits.
> 
> therefore RegfileArray n_regs = nregs

I'm very confused by this, is n_regs internal to RegFileArray while nregs is
derived from n_regs for VirtualPort?

> 
> however RegfileArray regwidth is bitwidth DIVIDED by n_regs.

Where is regwidth used? I assume it's important but I am missing/have missed
something.

> then, in the constructor, add n_regs read ports and n_regs write ports to a
> pair of lists.
> 
> you can see this being done in soc.regfile.regfiles here
> 
> https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/regfile/regfiles.py;
> h=d6f3a8dd79930d1286c72a42328363d9b9b8e9f3;hb=HEAD#l42
> 
> except, that should be a for loop
> 
> 
> next, we want an EXTRA read port and an extra write port.

Does this mean that I should keep them as separate variables outside of the
wr_ports and rd_ports lists as I have done in my first commit for this?

> this should, for data, instead of being only bitwidth/nregs wide, should
> instead be the FULL bitwidth wide. 
> 
> however the enable lines should be nregs wide.
> 
> 39         port = RecordObject([("ren", nregs),
>   40                              ("data_o", bitwidth)],
>   41                             name=name)
> 
> like that.
> 
> 
> then, in the elaborate:
> 
> * if any of the "extra" port ren bits are set, the data is sent through the
> corresponding *lower* indexed ports.

I was unable to determine how to route the data through the corresponding lower
indexed ports, I suspect it might have something to do with the below code from
regfile.py, but I was unable to make heads or tails of it either way:
```
144  for (regs, p) in self._rdports:
145     #print (p)
146     m.d.comb += self._get_en_sig(regs, 'ren').eq(p.ren)
147     ror = treereduce(list(regs))
148     m.d.comb += p.data_o.eq(ror)
```

Some explicit guidance here in particular would be really helpful, as I think
this might be the thing I have the least idea of how to go about implementing.
I assume that my function should match each bit to its corresponding 'enabled'
port but I'm only about 10% sure which variable or 'named parameter' I access
this through.

I apologize that I just don't understand a good portion of your instructions,
but I think that's because I'm learning how to understand and communicate in
the esoteric language of hardware, as well as the terminology that is specific
to our project. If it's something else, I'd sure like to know so I can work to
remedy it.

> you see how that works?

Hehe I think, as you can see, I don't, but I hope to through working through
this :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  1:45 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

Cole Poirier <colepoirier@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colepoirier@gmail.com

--- Comment #4 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #2)
> https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=HEAD
> 
> saw this.

Thanks! I'm trying to get something down, so I don't freeze because there are
multiple things I don't understand.

> 
> i think... actually... the list  of ports in the constructor, have to be
> done manually, then those wired via a mux to the "real" ports
> 
> so a for loop adds RecordObjects
> 
> ren=1, data=bitwidth/nregs
> 
> then appends an *extra* on
> ren=nregs, data=bitwidth

Pushed a commit with this change, not sure if it's exactly right yet.

> 
> then in the constructor:
> 
> * test port[-1].ren == 0
> 
> * if zero then for all ports 0 to nregs, connect *internal* port to external
> port
> 
> * else put bitwidth/nregs bits of port[-1].data onto port[loopindex].data
> and also do same with enable bits.

Can you help me undestand how I should set the interal and external ports up in
the __init__() function? I'm lost here as to how these should be represented in
code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  2:03 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #5 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #3)
> (In reply to Luke Kenneth Casson Leighton from comment #1)
> 
> Unfortunately I had quite a lot of difficulty trying to follow your
> instructions.

v. late and using phone. sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  2:08 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #6 from Cole Poirier <colepoirier@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #5)
> (In reply to Cole Poirier from comment #3)
> > (In reply to Luke Kenneth Casson Leighton from comment #1)
> > 
> > Unfortunately I had quite a lot of difficulty trying to follow your
> > instructions.
> 
> v. late and using phone. sorry.

No problem, end of day here. I will be back online at 1600 utc (9am pst or
daylight whatever, NA west coast time). If the time sensitivity of this is
within that time period feel free to complete this in my absence, otherwise,
see you tomorrow afternoon (for you).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  2:09 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #7 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cole Poirier from comment #4)
> (In reply to Luke Kenneth Casson Leighton from comment #2)
> > https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=HEAD
> > 
> > saw this.
> 
> Thanks! I'm trying to get something down, so I don't freeze because there
> are multiple things I don't understand.
> 
> > 
> > i think... actually... the list  of ports in the constructor, have to be
> > done manually, then those wired via a mux to the "real" ports
> > 
> > so a for loop adds RecordObjects
> > 
> > ren=1, data=bitwidth/nregs
> > 
> > then appends an *extra* on
> > ren=nregs, data=bitwidth
> 
> Pushed a commit with this change, not sure if it's exactly right yet.

not seen it.

2nd commit needs to add a *SECOND* pair of lists.

to 2nd set, *manually* add RecordObjects.  do not use readport() or writeport()
 function.  *MANUALLY* add multiple RecordObjects.

these are the "external" where the 1st set is "internal".

> > 
> > then in the constructor:

i meant "elaborate" here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 324] create POWER9 DIV pipeline
From: bugzilla-daemon @ 2020-05-26  3:55 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-324-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=324

--- Comment #5 from Jacob Lifshay <programmerjake@gmail.com> ---
I wrote a simple Rust program that runs different Power instructions (just div*
and mod* for now) and put the results here:
https://salsa.debian.org/Kazan-team/power-instruction-analyzer/-/blob/master/output-for-initial-2-ga7250d2.txt

Source here:
https://salsa.debian.org/Kazan-team/power-instruction-analyzer

result_prev is assigned to the result register before executing the tested
instruction since sometimes processors just skip writing to a register in
exceptional cases

From what I can tell, for all error cases for div and mod instructions, POWER9
just writes 0 to the result register.

For the instructions with just 32-bit results, from what I can tell from a
relatively small number of test cases, it zero extends for all signed/unsigned
div instructions, zero extends for unsigned mod instructions, and sign extends
for signed mod instructions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26  4:07 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

Jacob Lifshay <programmerjake@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |programmerjake@gmail.com

--- Comment #8 from Jacob Lifshay <programmerjake@gmail.com> ---
(In reply to Cole Poirier from comment #6)
> No problem, end of day here. I will be back online at 1600 utc (9am pst or
> daylight whatever, NA west coast time).

Pacific Daylight Time (PDT)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* Re: [libre-riscv-dev] [OpenPOWER-HDL-Cores] Power ISA v3.1 bug - parityw
From: Paul Mackerras @ 2020-05-26  5:44 UTC (permalink / raw)
  To: Michael Nolan; +Cc: openpower-hdl-cores, Libre-RISCV General Development
In-Reply-To: <48876f64-f3fa-c616-6710-ba773c89173c@gmail.com>

On Fri, May 15, 2020 at 11:07:12AM -0400, Michael Nolan wrote:
> Hello! I'm with the Libre-SOC team, and was working on testing our
> implementation of the parityw and parityd instructions when I came across
> the following bug in the specification. The specification describes prtyd as
> follows:
> 
> s <- 0
> 
> do i = 0 to 7
> 
>     s <- s (XOR) RS[i%8 + 7]
> 
> RA <- 63'b0 || s
> 
> The least significant bit in each byte of the contents of register RS is
> examined. If there is an odd number of one bits the value 1 is placed into
> register RA; otherwise the value 0 is placed into register RA.
> 
> 
> 
> The description of "least significant bit in each byte" leads me to believe
> that RS[i%8 + 7] should really be RS[i*8+7]. This is also how it is
> implemented in microwatt

Right, and microwatt matches POWER9, so POWER9 implements "*" as well.

I have asked the IBM architects for confirmation, and I'll let you
know what they say.  For now I think it's pretty safe to go ahead with
"*", since "*" is clearly what existing software expects.

Paul.

_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 155] a PLL is needed for the SoC
From: bugzilla-daemon @ 2020-05-26  9:00 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-155-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=155

--- Comment #13 from Dimitri Galayko <dimitri.galayko@lip6.fr> ---
Dear all, I'm following the discussion by mail with Luke. There is a need to
create a "open-source" and generic PLL with the following specifications: 

Technology: TSMC 180 nm
Input: 24 MHz XTAL
Output Frequency: ~300 MHz (~x12), with fractional intermediate frequencies x2,
x3, x4, x5, x6. A double of the frequency needs to be generated, in order to
have a 300 MHz well-balanced 1 and 0 phases. 

Goal : to include to October tape-out
Power: TBD -- the whole chip is expected to consume 3 watts 
Jitter specifications : TBD 

I believe that an all-digital PLL can be a good first approach, if the design
needs to be “generic”. The most critical and difficult block is the digitally
controlled oscillator, which defines greatly the performances of the whole. 

We have a multiple experience of design of all-digital PLLs, whose basic blocks
(mainly DCO and phase detector) have been inspired from the work (done in 65 nm
CMOS)
**Tierno, Jose A., Alexander V. Rylyakov, and Daniel J. Friedman. "A wide power
supply range, wide tuning range, all static CMOS all digital PLL in 65 nm SOI."
IEEE Journal of Solid-State Circuits 43.1 (2008): 42-51. **
A detailed report on what have been done in my team is available in the PhD
report (in english, available on the web)
**Shan, Chuan. Générateur distribué d'horloge pour puces globalement et
localement synchrones de grande taille. Diss. Paris 6, 2014.** 

The advantage of this approach is a compatibility with the digital design flow,
all blocks belong to the digital electronics (even if some of them require a
custom sizing). I believe that this is well suitable for the goal of a
“generic” design flow. After that, it is possible that the performances will
not be satisfactory in 180 nm (mainly the power consumption), I have some idea
about possible alternative. 

My first simulations in a 180 nm technology (not TSMC, but equivalent) shows
that a 8 bits DCO may ensure a 600 MHz output frequency for all corners with a
resolution able to provide a reasonably good jitter performance, with the power
consumption of ~5mW.  

So, regarding the specifications, the most important point determining the
overall architecture is : 
-- Jitter 
-- power consumption. 

Is there any idea about what is expected for these two specifications ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-26 10:01 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

--- Comment #36 from Cesar Strauss <cestrauss@gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #35)
> it will be fascinating to compare against the formal proof

I saw src/soc/fu/compunits/formal/proof_fu.py. Very interesting.

How about a formal proof of the ALU interface?

Also, maybe DummyALU could be truly dummy (doesn't drive its signals), and let
Assume drive them, in the CompUnit formal proof.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 336] ALU CompUnit needs to recognise that RA (src1) can be zero
From: bugzilla-daemon @ 2020-05-26 10:15 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-336-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=336

--- Comment #37 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Cesar Strauss from comment #36)
> (In reply to Luke Kenneth Casson Leighton from comment #35)
> > it will be fascinating to compare against the formal proof
> 
> I saw src/soc/fu/compunits/formal/proof_fu.py. Very interesting.

it is also very "clean".

> How about a formal proof of the ALU interface?

the interaction with it will be needed, yes, because of the signalling
ready/valid.

in particular the ALU may *not* necessarily be ready to proceed at the time
operands are available.

> Also, maybe DummyALU could be truly dummy (doesn't drive its signals), and
> let Assume drive them, in the CompUnit formal proof.

i have no idea.  we do need some way to check that data actually gets passed
through.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 155] a PLL is needed for the SoC
From: bugzilla-daemon @ 2020-05-26 10:24 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-155-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=155

--- Comment #14 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
(In reply to Dimitri Galayko from comment #13)
> Dear all, I'm following the discussion by mail with Luke. There is a need to
> create a "open-source" and generic PLL with the following specifications: 
> 
> Technology: TSMC 180 nm
> Input: 24 MHz XTAL
> Output Frequency: ~300 MHz (~x12), with fractional intermediate frequencies
> x2, x3, x4, x5, x6.

as taps, this would be very helpful, so as to be able to do further
counter-dividers to create a wide frequency range for peripherals.

> A double of the frequency needs to be generated, in
> order to have a 300 MHz well-balanced 1 and 0 phases. 

interesting.  600mhz in 180nm.

> My first simulations in a 180 nm technology (not TSMC, but equivalent) shows
> that a 8 bits DCO may ensure a 600 MHz output frequency for all corners with
> a resolution able to provide a reasonably good jitter performance, with the
> power consumption of ~5mW.  

this sounds perfectly reasonable.

> So, regarding the specifications, the most important point determining the
> overall architecture is : 
> -- Jitter 
> -- power consumption. 
> 
> Is there any idea about what is expected for these two specifications ?

5mW is perfectly acceptable.  we do not have enough experience to say if jitter
is an issue, and for this first chip, being a noncritical test chip, if it is
unstable due to jitter we simply run tests at a slower speed, incrementally,
until it is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 216] LOAD STORE buffer needed
From: bugzilla-daemon @ 2020-05-26 12:50 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-216-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=216

--- Comment #45 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
tobias, i just noticed in soc.regfile.regfile.py, this code:

    def elaborate(self, platform):
        m = Module()
        for (regs, p) in self._rdports:
            #print (p)
            ror = treereduce(list(regs))
            m.d.comb += p.data_o.eq(ror)

that's pretty much exactly what is needed for DataMerger.  the ORing of
all of the data together (from only those with a "match" in the selected row,
though), is "it".

however bear in mind, both the enable *and* data signals need to be merged
out.  you may need to do them separately: one treereduce for the en and another
for the data, both "optionally" controlled by the match on the selected row.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

* [libre-riscv-dev] [Bug 351] create a "block" (mass) regfile port (read and write) onto an array-based regfile
From: bugzilla-daemon @ 2020-05-26 12:54 UTC (permalink / raw)
  To: libre-riscv-dev
In-Reply-To: <bug-351-13@https.bugs.libre-soc.org/>

https://bugs.libre-soc.org/show_bug.cgi?id=351

--- Comment #9 from Luke Kenneth Casson Leighton <lkcl@lkcl.net> ---
ok i am more awake.  started on adding the virtual port aaaand... spangg, i
ran smack into a pre-existing very close approximation of the virtual port,
in the form of RegFileArray.

*face-palm*.

the way that RegFileArray works is: it creates an array of registers,
then when read_port (or write_port) is called, an *array* of individual
read/write ports - one for each individual register - is returned, *and*
a "global" access port is provided.

that global access port is a "broadcast bus" to every register, and its
width is the *exact* same width as the register width.

also, where each register has a 1-bit-wide ren/wen, the global port is
the *accumulation* of all those signals (using self._get_en_sig) in a
unary sequence.

thus, if you pass in say a global.ren="0b00001011", this will read out the OR
of registers numbered 0, 1 *and* 3 (!!) as in:

    result = reg[0] ORed with reg[1] ORed with reg[3]

this will be a regwidth-wide result

what we want, for the virtual port is:

    result = reg[0] CATted with reg[1] CATted with reg[2] CATed with reg[3]...

this will be a regwidth TIMES n_regs wide result

which is very different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
libre-riscv-dev mailing list
libre-riscv-dev@lists.libre-riscv.org
http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev

^ permalink raw reply

page:   latest

Libre RISC-V Mailing list Archives (accessible via public-inbox)

Archives are clonable: git clone --mirror https://inbox.libre-soc.org/libre-riscv-dev

Example config snippet for mirrors


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git